_spawn_metadata_agent function name should be _spawn_metadata_proxy

Bug #1092047 reported by yong sheng gong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
yong sheng gong

Bug Description

l3_agent.py:
def _spawn_metadata_agent(self, router_info):
        def callback(pid_file):
            return ['quantum-ns-metadata-proxy',
                    '--pid_file=%s' % pid_file,
                    '--router_id=%s' % router_info.router_id,
                    '--state_path=%s' % self.conf.state_path]

        pm = external_process.ProcessManager(
            self.conf,
            router_info.router_id,
            self.conf.root_helper,
            router_info.ns_name())
        pm.enable(callback)

    def _destroy_metadata_agent(self, router_info):
        pm = external_process.ProcessManager(
            self.conf,
            router_info.router_id,
            self.conf.root_helper,
            router_info.ns_name())
        pm.disable()

Revision history for this message
Maru Newby (maru) wrote :

I'm curious - are all trivial refactoring efforts going to be tracked as bugs in the future?

Revision history for this message
yong sheng gong (gongysh) wrote :

for some purposes:
1. track
2. discussion
3. let others to fix
4. fix it later

Changed in quantum:
assignee: nobody → yong sheng gong (gongysh)
importance: Undecided → Low
milestone: none → grizzly-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19067

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/19067
Committed: http://github.com/openstack/quantum/commit/e0e5101b876f7754e13d7bd8e045438f0c966af2
Submitter: Jenkins
Branch: master

commit e0e5101b876f7754e13d7bd8e045438f0c966af2
Author: gongysh <email address hidden>
Date: Mon Jan 7 10:12:00 2013 +0800

    change xxx_metadata_agent() into xxx_metadata_proxy()

    Bug #1092047

    Change-Id: Ic59da98105a7301697ecb5a6477f3c7fc3f8e86a

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.