Ubuntu
update-manager package

sru request for update-manager

Bug #109584 reported by Michael Vogt
2
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
In Progress
Undecided
Unassigned

Bug Description

Binary package hint: update-manager

Sru request for update-manager:

update-manager (1:0.59.22) feisty-proposed; urgency=low

  * DistUpgrade/DistUpgradeControler.py:
    - fix free space check when the dir checked is a symlink
      (LP#106804)
    - increase minAge for the apt cleanup cron job during the upgrade
      to fix race for people with very slow network (LP#109548)
  * cdromupgrade:
    - do not call any authentication mechanism, that is the
      responsibility of the user (LP#107431)
  * DistUpgrade/DistUpgradeViewKDE.py:
    - fix a bug in the cdrom progress (LP#107451)
  * DistUpgrade/DistUpgradeViewText.py:
    - send correct package failure information to log (LP#109209)
  * DistUpgrade/crashdialog.ui
    - Fix bug report URL in crash dialogue (LP#108969)
  * UpdateManager/Core/MetaRelease.py:
    - fix in I-M-S 304 handling (LP#109216)
  * DistUpgrade/DistUpgradeCache.py:
    - check RemovalBlacklist early when removing a package to
      work-around crash in problem resolver (LP#109014)

 -- Michael Vogt <email address hidden> Tue, 24 Apr 2007 12:59:59 +0200

Each change has a diff in codebrowser, I will attach a full debdiff here for completness

Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

TBH I do not think that bug 109548 is appropriate for an SRU. It has a lot of newly introduced code, modifies configuration files, etc. and the potential impact is not high enough to warrant destabilization (after all, running u-m again should usually fix it?)

Same applies for bug 107451; although the fix is small, it is only cosmetical.

changelog bug: #109209 is attributed to DistUpgradeViewText.py, but is apparently fixed in DistUpgradeView.py.

Can you please give a proper rationale why #106804 needs to go into stable?

Please generally be more verbose in the changelog; 'fix a bug in foo.py' is irrelevant, other descriptions are ok, but should be augmented with explaining the actual impact.

Changed in update-manager:
status: Unconfirmed → Needs Info
Revision history for this message
Michael Vogt (mvo) wrote :

Bug #109548 impact people with very slow networks or people leting the upgrade run for a long time (e.g. over the weekend). Then it can happen that the apt cleanup job just deletes some of the downloaded debs. I'm ok with leaving it out as it affects only a fraction of the people.

I can revert most of the changes for bug #107451 but the DistUpgradeViewKDE.py change is crucial and trivial for people who want to upgrade with kde.

Thanks for pointing out #109209, I corrected that, I removed bug #106804, it affect people who e.g. have /var/cache/apt/archives symlinked to a different parition with more space. The free-spacer checker currently does not get this and will check the incorrect space.

I will attached a updated debdiff.

Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

Updated debdiff looks good now, approved.

Changed in update-manager:
status: Needs Info → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

I will mark this as a dup of an arbitrary other bug that is fixed in that SRU.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.