all signal handlers have been removed in error

Bug #1101154 reported by James Hunt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-session (Ubuntu)
Expired
Undecided
Unassigned

Bug Description

gnome-session/main.c has disabled all signal handling, but intention was seemingly to only disable SIGSEGV signal handing:

10:43 <jodh> chrisccoulson: hi - I'm looking at how gnome-session currently
             shuts down and trying to understand why the following is
             commented out: http://paste.ubuntu.com/1544640/
10:44 <chrisccoulson> jodh, IIRC it was to stop gnome-session from swallowing
                      those signals so we got crash reports with apport
10:44 <chrisccoulson> but this was a long time ago ;)
10:49 <jodh> chrisccoulson: ok, thanks.
10:49 <chrisccoulson> jodh, technically, i think only the call to
                      gdm_signal_handler_add_fatal() needs to be commented out
10:49 <chrisccoulson> i can't remember why we disabled all signal handling
10:50 <chrisccoulson> i've slept and drank beer since then ;)
10:50 <pitti> chrisccoulson: or perhaps a merge error? in the original patch
              the commented out section might only have been for SIGSEGV, and
              in newer upstream versions the SIGTERMs got added?
10:52 <chrisccoulson> pitti, yeah, you're right
10:52 <chrisccoulson> the original patch was
                      http://bazaar.launchpad.net/~ubuntu-desktop/gnome-session/ubuntu/revision/18
10:52 <chrisccoulson> jodh ^^
10:53 <chrisccoulson> it got changed here by seb128:
                      http://bazaar.launchpad.net/~ubuntu-desktop/gnome-session/ubuntu/revision/233
10:53 <chrisccoulson> not sure why ;)
10:53 <pitti> that doesn't look intended
10:54 <chrisccoulson> jodh, so, the short summary is - the patch is only meant
                      to disable the SEGV handler ;)

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Thank you for reporting this bug and helping to make Ubuntu better.

I apologize for the delay. This isn't really my area of expertise so could you please include some more information so I can test and verify whether a fix works:

1. the specific steps or actions you took that caused you to encounter the problem,
2. the behavior you expected, and
3. the behavior you actually encountered (in as much detail as possible).

Changed in gnome-session (Ubuntu):
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for gnome-session (Ubuntu) because there has been no activity for 60 days.]

Changed in gnome-session (Ubuntu):
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.