libapache2-mod-rpaf has wrong name in conf file

Bug #1126233 reported by Kurt Huwig
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
libapache2-mod-rpaf (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Louis Bouchard

Bug Description

SRU justification :

rpaf module is not correctly enabled without this modification

Impact :

rpaf module not working as expected

Fix :

Backport Quantal syntax used for that module which correctly set the module name
to rpaf_module

Test Case :

The file /etc/apache2/mods-available/rpaf.conf should contain the following :

<IfModule rpaf_module>
RPAFenable On
RPAFsethostname On
RPAFproxy_ips 127.0.0.1 ::1
</IfModule>

Regression :

None, this modification is already in Quantal and only implemented if
libapache2-mod-rpaf is in use.

Original description of the problem :

In the file /etc/apache2/mods-available/rpaf.conf it reads

<IfModule mod_rpaf.c>

which is for Apache 1.3 but the modules is called mod_rpaf-2.0.c for Apache 2.x, so it must be

<IfModule mod_rpaf-2.0.c>

Here

http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise/libapache2-mod-rpaf/precise/view/head:/debian/rules

you can see, that mod_rpaf-2.0.c is compiled and renamed to mod_rpaf.so:

apxs2 -c -o mod_rpaf.so mod_rpaf-2.0.c

Revision history for this message
Sergey B Kirpichev (skirpichev) wrote :

libapache2-mod-rpaf (0.6-3) unstable; urgency=low

   * Fixed module naming stuff in rpaf.conf (Thanks to Alexander
     Kuznetsov). Closes: #653330.
[...]

This fix is in The Quantal Quetzal (current stable release).

Changed in libapache2-mod-rpaf (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in libapache2-mod-rpaf (Ubuntu Precise):
status: New → Confirmed
Louis Bouchard (louis)
Changed in libapache2-mod-rpaf (Ubuntu Precise):
assignee: nobody → Louis Bouchard (louis-bouchard)
status: Confirmed → In Progress
Revision history for this message
Louis Bouchard (louis) wrote :

debdiff of the backported quantal fix for precise

description: updated
Revision history for this message
Adam Conrad (adconrad) wrote :

Uploaded to precise-proposed.

Revision history for this message
Dave Walker (davewalker) wrote : Please test proposed package

Hello Kurt, or anyone else affected,

Accepted libapache2-mod-rpaf into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libapache2-mod-rpaf/0.6-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libapache2-mod-rpaf (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Eduardo Damato (edamato)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Scott Kitterman (kitterman) wrote :

Inspecting the .deb at https://launchpad.net/ubuntu/precise/i386/libapache2-mod-rpaf/0.6-2ubuntu1 it doesn't seem to be fixed per the bug description. The full /etc/apache2/mods-available/rpaf.conf in that package is:

<IfModule rpaf_module>
RPAFenable On
RPAFsethostname On
RPAFproxy_ips 127.0.0.1 ::1
</IfModule>

Either the test case is wrong or the package is wrong.

tags: added: verification-failed
removed: verification-done
Revision history for this message
Louis Bouchard (louis) wrote :

@scott:

What appears in the debdiff is what is present in Saucy. The existing modification is slightly different from what was proposed in the patch and it does indeed fix the problem, just like it does in saucy.

 Maybe that should have been verified before pulling the package out of -proposed as this has been tested by at least two different person including myself.

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 1126233] Re: libapache2-mod-rpaf has wrong name in conf file

It hasn't been removed.

Please correct the test case and mark it verification-done then.

Revision history for this message
Louis Bouchard (louis) wrote :

This is the change as it appears in Saucy :

http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/saucy/libapache2-mod-rpaf/saucy/view/head:/debian/rpaf.conf

Can this package please be released into -updates ?

Revision history for this message
Louis Bouchard (louis) wrote :

Then I must be missing the obvous : The test case above says :

The file /etc/apache2/mods-available/rpaf.conf should contain the following :

<IfModule rpaf_module>
RPAFenable On
RPAFsethostname On
RPAFproxy_ips 127.0.0.1 ::1
</IfModule>

Testing it on Precise-proposed a minute ago gives me :

$ cat /etc/apache2/mods-available/rpaf.conf
<IfModule rpaf_module>
RPAFenable On
RPAFsethostname On
RPAFproxy_ips 127.0.0.1 ::1
</IfModule>

This is coherent with the content of the debdiff. What am I missing here ?

Revision history for this message
Scott Kitterman (kitterman) wrote :

My mistake. I misread the test case. I read it as this being the relevant bit:

... so it must be

<IfModule mod_rpaf-2.0.c>

It's fine. Sorry for the confusion.

tags: added: verification-done
removed: verification-failed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libapache2-mod-rpaf - 0.6-2ubuntu1

---------------
libapache2-mod-rpaf (0.6-2ubuntu1) precise; urgency=low

  * debian/conf/rpaf.conf : Fixes invalid module name
    by backporting existing fix from Quantal (LP: #1126233)
 -- Louis Bouchard <email address hidden> Wed, 28 Aug 2013 16:09:47 +0200

Changed in libapache2-mod-rpaf (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.