Unity

cppcheck reports true positives

Bug #1131152 reported by MC Return
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Undecided
MC Return
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[unity-shared/LayoutSystem.cpp:261]: (warning) Member variable 'LayoutWindow::alpha' is not initialized in the constructor.

[unity-shared/DashStyle.cpp:981] -> [unity-shared/DashStyle.cpp:983]: (performance) Variable 'odd' is reassigned a value before the old one has been used.

[shortcuts/ShortcutHintPrivate.cpp:38]: (style) Unsigned variable 'index' can't be negative so it is unnecessary to test it.

[plugins/unityshell/src/unity-util-accessible.cpp:289]: (error) Memory leak: atk_event

Related branches

lp:~mc-return/unity/unity.merge-fix1131152-cppcheck-issues
Andrea Azzarone (community): Approve
PS Jenkins bot: Pending (continuous-integration) requested
Diff: 54 lines (+5/-6)
4 files modified
plugins/unityshell/src/unity-util-accessible.cpp (+1/-0)
shortcuts/ShortcutHintPrivate.cpp (+2/-4)
unity-shared/DashStyle.cpp (+1/-2)
unity-shared/LayoutSystem.cpp (+1/-0)
MC Return (mc-return)
Changed in unity:
assignee: nobody → MC Return (mc-return)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog

Changed in unity:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 6.12.0daily13.02.26-0ubuntu1

---------------
unity (6.12.0daily13.02.26-0ubuntu1) raring; urgency=low

  [ Andrea Azzarone ]
  * Multi-monitor - Panel and launcher visible on top of multimonitor
    non-focused fullscreen apps (LP: #748539)
  * unity.tests.launcher.test_icon_behavior.LauncherIconsTests.* fails
    randomly (LP: #1131679)

  [ Xiao-Long Chen ]
  * Add timeout before removing launcher (LP: #1119801)

  [ MC Return ]
  * cppcheck reports true positives (LP: #1131152)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 3171
 -- Automatic PS uploader <email address hidden> Tue, 26 Feb 2013 04:02:40 +0000

Changed in unity (Ubuntu):
status: New → Fix Released
Andrea Azzarone (azzar1)
Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.