Launchpad itself

Null bug supervisor is confusing

Bug #113825 reported by Matthew Paul Thomas
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Steve Kowalik

Bug Description

Currently it is possible in the UI for a project's bug supervisor to be null, which makes the apparent behavior of private bugs less obvious. (The bug supervisor is subscribed to initially-private bug reports, unless there is no bug supervisor, in which case...)

This can be fixed by representing a null bug supervisor as "Project maintainer" in the UI. For example, in the "Change bug contact" page:

    Bug supervisor:
    (*) Project maintainer (currently _Foo Bar_)
    ( ) [__________________] (Choose...)

See original description

Related branches

lp:~stevenk/launchpad/no-structsub-for-bug-supervisor
William Grant: Approve (code)
Diff: 1612 lines (+92/-552)
39 files modified
lib/lp/bugs/browser/bugrole.py (+1/-46)
lib/lp/bugs/browser/bugsupervisor.py (+3/-12)
lib/lp/bugs/browser/bugtarget.py (+3/-6)
lib/lp/bugs/browser/tests/bugtarget-filebug-views.txt (+1/-1)
lib/lp/bugs/browser/tests/bugtask-edit-views.txt (+1/-1)
lib/lp/bugs/browser/tests/test_bugnomination.py (+2/-2)
lib/lp/bugs/browser/tests/test_bugsupervisor.py (+4/-80)
lib/lp/bugs/browser/tests/test_bugtarget_configure.py (+2/-13)
lib/lp/bugs/browser/tests/test_bugtask.py (+4/-7)
lib/lp/bugs/browser/tests/test_expose.py (+1/-2)
lib/lp/bugs/doc/bugsubscription.txt (+13/-61)
lib/lp/bugs/doc/bugtask-search.txt (+2/-2)
lib/lp/bugs/doc/initial-bug-contacts.txt (+1/-46)
lib/lp/bugs/interfaces/bugsupervisor.py (+3/-23)
lib/lp/bugs/interfaces/bugtask.py (+2/-4)
lib/lp/bugs/model/tests/test_bug.py (+2/-6)
lib/lp/bugs/model/tests/test_bugsubscriptioninfo.py (+3/-7)
lib/lp/bugs/model/tests/test_bugtask.py (+4/-9)
lib/lp/bugs/model/tests/test_bugtask_status.py (+4/-6)
lib/lp/bugs/model/tests/test_bugtasksearch.py (+3/-4)
lib/lp/bugs/stories/bugtask-management/xx-bug-importance-change.txt (+4/-4)
lib/lp/bugs/stories/bugtask-management/xx-change-assignee.txt (+1/-1)
lib/lp/bugs/stories/bugtask-management/xx-edit-email-address-bugtask.txt (+2/-2)
lib/lp/bugs/stories/bugtask-management/xx-view-editable-bug-task.txt (+1/-1)
lib/lp/bugs/stories/guided-filebug/xx-ubuntu-filebug.txt (+1/-1)
lib/lp/bugs/tests/bugs-emailinterface.txt (+2/-2)
lib/lp/bugs/tests/has-bug-supervisor.txt (+0/-66)
lib/lp/bugs/tests/test_bug.py (+1/-1)
lib/lp/bugs/tests/test_bugcontact.py (+0/-40)
lib/lp/bugs/tests/test_bugvisibility.py (+1/-3)
lib/lp/registry/browser/product.py (+3/-8)
lib/lp/registry/browser/tests/test_edit_permissions.py (+4/-6)
lib/lp/registry/browser/tests/test_subscription_links.py (+9/-31)
lib/lp/registry/configure.zcml (+2/-4)
lib/lp/registry/doc/private-team-roles.txt (+2/-2)
lib/lp/registry/interfaces/product.py (+0/-2)
lib/lp/registry/model/distribution.py (+0/-7)
lib/lp/registry/model/product.py (+0/-7)
lib/lp/registry/tests/test_product.py (+0/-26)
Björn Tillenius (bjornt)
Changed in malone:
status: New → Triaged
Revision history for this message
Robert Collins (lifeless) wrote : Re: Null bug contact is confusing

So this is (or was) true; we should fix it but this only really affects initial setup - so I don't think it qualifies as high given the other high bugs we have today.

Changed in launchpad:
importance: Undecided → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

From the duplicate that describes the issue caused by an ambiguous model and UI:

If a project has no bug supervisor set, the owner is notified of all bug changes. Unlike the bug supervisor, they have no option to unsubscribe.

A workaround is to set the bug supervisor to the owner, then remove the subscription.

The problematic bit is this:

    def getAlsoNotifiedSubscribers(self, recipients=None, level=None):
        [snip]
            # If the target's bug supervisor isn't set,
            # we add the owner as a subscriber.
            pillar = bugtask.pillar
            if pillar.bug_supervisor is None:
                also_notified_subscribers.add(pillar.owner)
                if recipients is not None:
                    recipients.addRegistrant(pillar.owner, pillar)

summary: - Null bug contact is confusing
+ Null bug supervisor is confusing
description: updated
Curtis Hovey (sinzui)
description: updated
Curtis Hovey (sinzui)
tags: added: confusing-ui
Revision history for this message
Robert Collins (lifeless) wrote :

This has also led to bugs in the code where the model property is consulted via sql rather than the calculated value (see the recent 'cannot ave private bugs w/out a bug supervisor' bug).

William Grant (wgrant)
tags: added: disclosure
Curtis Hovey (sinzui)
tags: added: sharing
Revision history for this message
Robert Collins (lifeless) wrote :

This special case will be going soon. Yay.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15817 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15817>.

Changed in launchpad:
assignee: nobody → Steve Kowalik (stevenk)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.