Warning after installing other language packs

Bug #1145178 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Son Nguyen

Bug Description

Version: master
Platform: all
Browser: all

After installing a language pack such as fr from langpacks.mahara.org.
There is a form at the top for changing the language.

Warning issues:

[WAR] ee (lib/pieforms/pieform.php:1408) Pieform element languageselect_lang wants to add headdata to the page, but it's too late. Build your form before generating the page.
Call stack (most recent first):
log_message("Pieform element languageselect_lang wants to add h...", 8, true, true) at /home/sonn/code/mahara/htdocs/lib/errors.php:109
log_warn("Pieform element languageselect_lang wants to add h...") at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:1408
Pieform->build_element_html(array(size 13)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:659
Pieform->build() at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:162
Pieform::process(array(size 5)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 5)) at /home/sonn/code/mahara/htdocs/lib/web.php:3604
language_select_form() at /home/sonn/code/mahara/htdocs/lib/web.php:478
smarty() at /home/sonn/code/mahara/htdocs/index.php:93

Revision history for this message
Son Nguyen (ngson2000) wrote :
Son Nguyen (ngson2000)
Changed in mahara:
milestone: none → 1.7.0
assignee: nobody → Son Nguyen (ngson2000)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Son Nguyen (ngson2000) wrote :
Revision history for this message
Son Nguyen (ngson2000) wrote :

Test cases:

1. Install a fresh Mahara site
2. Add another language, e.g fr.master.gz from http://langpacks.mahara.org/
3. Make sure there is no warnings when access the top page without login and changing the language

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2051
Committed: http://gitorious.org/mahara/mahara/commit/efec2f706fec502d83f45a24f6c5ab8bad24a444
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit efec2f706fec502d83f45a24f6c5ab8bad24a444
Author: Son Nguyen <email address hidden>
Date: Fri Mar 15 10:16:19 2013 +1300

    Fix the warnings when adding more languages (Bug #1145178)

    Change-Id: I4a074cf366da1e0322e1eec3c60cdb32d0f61a65
    Signed-off-by: Son Nguyen <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.