Unity

CompWindow::syncPosition () function is deprecated and was removed in lp:compiz, r3639

Bug #1161285 reported by MC Return
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Medium
MC Return
unity (Ubuntu)
Fix Released
Medium
MC Return

Bug Description

We need to adjust lp:unity to keep it compatible with Compiz trunk.

Please see http://bazaar.launchpad.net/~compiz-team/compiz/0.9.9/revision/3639

The MP linked should fix this and make Unity 100% compatible with Compiz trunk again.

Note:
This Compiz change has not landed yet in lp:compiz/raring, so nothing is broken yet.
It won't hurt to merge this now though as CompWindow::syncPosition () is just an
empty function and does nothing currently, so removing it with this MP will just
increase Unity's performance marginally.

Note 2:
I also removed the bool sync from the UnityDialogWindow::moveToRect(CompRect currentRect)
function as this bool was just used to determine if syncPosition () should be called and
thus is also redundant now.

See original description

Related branches

lp:~mc-return/unity/unity.merge-fix1161285-syncPosition-needs-removal
PS Jenkins bot (community): Approve (continuous-integration)
Brandon Schaefer (community): Approve
Sam Spilsbury: Pending requested
Diff: 105 lines (+5/-15)
4 files modified
plugins/unitydialog/src/unitydialog.cpp (+4/-11)
plugins/unitydialog/src/unitydialog.h (+1/-1)
plugins/unityshell/src/WindowGestureTarget.cpp (+0/-1)
tests/test-gestures/compiz_mock/core/window.h (+0/-2)
MC Return (mc-return)
Changed in unity:
assignee: nobody → MC Return (mc-return)
status: New → In Progress
MC Return (mc-return)
description: updated
Brandon Schaefer (brandontschaefer)
Changed in unity:
importance: Undecided → Medium
Changed in unity (Ubuntu):
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → MC Return (mc-return)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog

Changed in unity:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 6.12.0daily13.03.29-0ubuntu1

---------------
unity (6.12.0daily13.03.29-0ubuntu1) raring; urgency=low

  [ Marco Trevisan (Treviño) ]
  * Empty trash dialog sometimes dont have the focus (LP: #807808)
  * Launcher - Trash and Storage device icons in the Launcher should be
    illuminated if folder is being viewed in Nautilus (LP: #1063830)

  [ MC Return ]
  * CompWindow::syncPosition () function is deprecated and was removed
    in lp:compiz, r3639 (LP: #1161285)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3257
 -- Ubuntu daily release <email address hidden> Fri, 29 Mar 2013 07:24:06 +0000

Changed in unity (Ubuntu):
status: In Progress → Fix Released
Andrea Azzarone (azzar1)
Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.