unity.deps contains unnecessary API dependencies
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Geary |
Fix Released
|
Undecided
|
Unassigned | ||
| libunity |
Fix Released
|
Undecided
|
Michal Hruby | ||
| libunity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The unity.deps file (required for Vala compilation) includes gee-1.0 as a dependency. However, libgee is not used by the vapi and therefore should not be included.
To quote from the Vala upstream bindings guide (from https:/
"The only other file that should be distributed is a deps file, which lists pkg-config names of any dependencies exposed in the public API."
In other words, if there are no libgee symbols in the API, libgee shouldn't be included in the deps file. It's quite possible some of the other libraries aren't needed for the API as well, I haven't checked.
This is a problem for us as it means we can't link against both libunity and libgee 0.8, since libunity's deps file causes Vala to pull in symbols for libgee 0.6, which causes the compiler to error out with a symbol conflict.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Michał Sawicz: Approve
- Paweł Stołowski (community): Needs Fixing
-
Diff: 26 lines (+4/-1)2 files modifiedconfigure.ac (+3/-0)
src/Makefile.am (+1/-1)
| Eric Gregory (eric-yorba) wrote | #1 |
| Changed in libunity: | |
| assignee: | nobody → Michal Hruby (mhr3) |
| status: | New → In Progress |
| Jim Nelson (yorba-jim) wrote | #2 |
| Changed in geary: | |
| status: | New → Fix Committed |
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in libunity: | |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in libunity (Ubuntu): | |
| status: | New → Fix Released |
| Changed in libunity: | |
| status: | Fix Committed → Fix Released |
| Changed in geary: | |
| status: | Fix Committed → Fix Released |
Corresponding Geary ticket is here: http://