Launchpad itself

Soyuz tests should use standard LP logger

Bug #117166 reported by Julian Edwards
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Many Soyuz tests use a "mock_logger" object for debug output and the code being tested has to pass around this logger object. Instead, the code should be using logging.getLogger() or simply directly use logging.debug()

See also bug 54348

See original description
Revision history for this message
Julian Edwards (julian-edwards) wrote :

When fixing this, we can also fix the fact that the doctests rely on the DEBUG output to check the email contents, when they should be looking at the output from pop_notifications(). See files l/c/l/doc/{nascentupload*.txt, distroreleasequeue-notifications.txt}

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Julian,
is this related to bug 54348?

Changed in soyuz:
status: Unconfirmed → Needs Info
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Diogo,

I would say that it's not a dupe but it's certainly related, yes. I imagine both can be fixed at the same time.

Diogo Matsubara (matsubara)
Changed in soyuz:
status: Needs Info → Confirmed
description: updated
Celso Providelo (cprov)
Changed in soyuz:
importance: Undecided → Medium
Revision history for this message
Celso Providelo (cprov) wrote :

not 1.1.7

Celso Providelo (cprov)
Changed in soyuz:
assignee: nobody → cprov
Celso Providelo (cprov)
Changed in soyuz:
milestone: 1.1.12 → 1.2.1
Revision history for this message
Julian Edwards (julian-edwards) wrote :

See also bug 106084

Changed in soyuz:
milestone: 1.2.1 → 1.2.3
Celso Providelo (cprov)
Changed in soyuz:
milestone: 1.2.3 → none
Curtis Hovey (sinzui)
Changed in soyuz:
assignee: Celso Providelo (cprov) → nobody
Julian Edwards (julian-edwards)
tags: added: tecj
tags: added: tech-debt
removed: tecj
Curtis Hovey (sinzui)
visibility: private → public
Revision history for this message
Robert Collins (lifeless) wrote :

Fixed, I believe in the great logger unification.

Revision history for this message
Robert Collins (lifeless) wrote :

But I may be wrong, so marking incomplete instead of fix released.

Revision history for this message
Robert Collins (lifeless) wrote :

And bah, let me add spam ;P - that wouldn't be right. Someone needs to either 'know', or check the code.

Changed in launchpad:
importance: Medium → Low
Revision history for this message
Julian Edwards (julian-edwards) wrote :

It's not fixed :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.