Evergreen

Staff client "search by" drop down doesn't obey sort filter

Bug #1183226 reported by Pasi Kallinen on 2013-05-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Evergreen	Won't Fix	Low	Unassigned

Bug Description

*EG master

When doing searches in the staff client, the latest searches list shows also the sort filter, such as "sort(titlesort)", and clicking on such searches puts the sort filter in the search box ... but the Sort by -drop down box doesn't show the current sorting method as selected.

Tags:

Ben Shum (bshum) on 2013-05-24

Changed in evergreen:
status:	New → Triaged

Pasi Kallinen (paxed) on 2013-07-15

Changed in evergreen:
assignee:	nobody → Pasi Kallinen (paxed)

Revision history for this message

Pasi Kallinen (paxed) wrote on 2013-07-15:

Fix in user/paxed/lp1183226 - Exposes the parsed sorting type to tt2 as ctx.search_sort, and if the sort parameter is not available in the URL, looks for sorting in the search query.

tags:	added: pullrequest
Changed in evergreen:
milestone:	none → 2.5.0-alpha1

Remington Steed (rjs7) on 2013-08-12

Changed in evergreen:
milestone:	2.5.0-alpha1 → 2.5.0-alpha2

Dan Wells (dbw2) on 2013-08-26

Changed in evergreen:
milestone:	2.5.0-alpha2 → 2.5.0-beta1

Dan Wells (dbw2) on 2013-09-29

Changed in evergreen:
milestone:	2.5.0-beta1 → 2.5.0-rc

Dan Wells (dbw2) on 2013-10-16

Changed in evergreen:
milestone:	2.5.0-rc → 2.5.1

Ben Shum (bshum) on 2013-12-06

Changed in evergreen:
milestone:	2.5.1 → 2.5.2

Dan Wells (dbw2) on 2014-01-17

Changed in evergreen:
milestone:	2.5.2 → 2.6.0-alpha1

Dan Wells (dbw2) on 2014-02-05

Changed in evergreen:
milestone:	2.6.0-alpha1 → 2.6.0-beta1

Dan Wells (dbw2) on 2014-02-27

Changed in evergreen:
milestone:	2.6.0-beta1 → 2.6.0-rc1

Evergreen Bug Maintenance (bugmaster) on 2014-04-07

Changed in evergreen:
assignee:	Pasi Kallinen (paxed) → nobody
milestone:	2.6.0-rc1 → 2.next

Revision history for this message

Kathy Lussier (klussier) wrote on 2014-08-26:

Branch needs to be rebased.

Kathy Lussier (klussier) on 2014-11-10

Changed in evergreen:
assignee:	nobody → Michael Peters (mrpeters)

Kathy Lussier (klussier) on 2014-11-10

Changed in evergreen:
assignee:	Michael Peters (mrpeters) → nobody

Revision history for this message

Kathy Lussier (klussier) wrote on 2014-11-10:

I'm removing the pullrequest tag for now since this branch needs to be rebased. According to discussion in IRC this morning, somebody with a good understanding of query parser will need to rebase the branch. We have somebody who is willing to test this branch, so it would be great if somebody could help get this branch back in order.

tags:

removed: pullrequest

Revision history for this message

Mike Rylander (mrylander) wrote on 2014-11-10:

Kathy,

I've rebased Pasi's branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp1183226-sort-in-recent-searches_rebase-and-signoff ... no major changes, just some tab/space changing and drift adjustment.

Kathy Lussier (klussier) on 2014-11-10

tags:

added: pullrequest

Michelle Purcell (purcellm05) on 2014-11-10

Changed in evergreen:
assignee:	nobody → Michelle Purcell (purcellm05)

Revision history for this message

Michelle Purcell (purcellm05) wrote on 2014-11-10:

search page 2 sb4.missourievergreen.png Edit (118.6 KiB, image/png)

The patch fixed the bug stated above, but seems to have introduced a new issue. In comparing the functionality between the code in the sandbox and the demo versions on mlnc4.mvlcstaff.org and demoevergreencatalog.com, I noticed that when you go to a bib record page for a search result sometimes the text for recent searches extends past the recent searches box and the formatting of the text of recent searches has changed.

Kathy Lussier (klussier) on 2014-11-11

Changed in evergreen:
assignee:	Michelle Purcell (purcellm05) → nobody

Revision history for this message

Kathy Lussier (klussier) wrote on 2014-11-11:

Thanks for the testing Michelle! I just took a look at this branch too. Prior to the branch, I noticed that #descending used to display at the beginning of the search query. Post-fix, it's tacked on that end without any spacing, which therefore takes up more space and pushes things over. I'm removing the pullrequest for now, but I'll take a closer look tomorrow to see if it could be an easy tweak.

tags:

removed: pullrequest

Revision history for this message

Terran McCanna (tmccanna) wrote on 2019-03-07:

Confirmed in 3.2.3 that clicking on a recent search such as "sort(authorsort) music depth(0)" does not alter the Sort By dropdown. However, it does search correctly, so I'm not sure whether it is still a relevant bug report or not.

tags:

added: search webstaffclient
removed: staffclient

Revision history for this message

Terran McCanna (tmccanna) wrote on 2021-02-11:

Marking this Won't Fix as the new Angular Staff Catalog interface is so different.