webbrowser-app

Ampersand not correctly escaped in titles when displayed in suggestions list

Bug #1187432 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
webbrowser-app
Fix Released
Medium
Olivier Tilloy
webbrowser-app (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Steps to reproduce:

 1) Open the browser, and browse to http://nytimes.com
 2) Wait for the page to be fully loaded, and notice how the title contains an ampersand (« The New York Times - Breaking News, World News & Multimedia »)
 3) Reveal the chrome, and tap in the address bar
 4) Wait for the suggestions list to appear, and inspect the title of the only entry

Expected result: « The New York Times - Breaking News, World News & Multimedia »

Actual result: « The New York Times - Breaking News, World News & Multimedia »

Related branches

lp:~osomon/webbrowser-app/suggestions-always-rich-text
PS Jenkins bot: Approve (continuous-integration)
Günter Schwann (community): Approve
Diff: 33 lines (+3/-2)
2 files modified
src/Ubuntu/Browser/Suggestions.qml (+1/-0)
tests/autopilot/webbrowser_app/tests/test_history.py (+2/-2)
lp:ubuntu/saucy-proposed/webbrowser-app
Ugo Riboni (uriboni)
Changed in webbrowser-app:
status: New → Confirmed
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Confirmed → In Progress
assignee: nobody → Olivier Tilloy (osomon)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:webbrowser-app at revision 160, scheduled for release in webbrowser-app, milestone ubuntu-13.04-month-5

Changed in webbrowser-app:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.20daily13.06.11-0ubuntu1

---------------
webbrowser-app (0.20daily13.06.11-0ubuntu1) saucy; urgency=low

  [ Olivier Tilloy ]
  * Ensure that the chrome won’t be automatically hidden while testing
    interaction with the toolbar. This should fix flaky autopilot tests.
  * More reliable way of asserting that a page has finished loading.
    This should make tests more robust.
  * Always format the suggestions as rich text, to ensure ampersands are
    not incorrectly escaped. (LP: #1187432)
  * Add translators comments for the keywords associated to HUD actions.
  * Enable multiple tabs in the browser. Only the basic functionality is
    in place, further iterations will refine the functionality and the
    visuals.
  * Make as many test cases as possible inherit from
    StartOpenRemotePageTestCaseBase. This should make them overall more
    robust by avoiding race conditions with the chrome automatically
    hiding when the homepage has finished loading.
  * Ensure the suggestions list is hidden when the panel is hidden. (LP:
    #1187871)
  * Open links with target="_blank" in a new tab.
  * Install custom click event handler on all frames as well as on the
    top-level document. (LP: #1159857, #1188575)
  * Escape some special characters before highlighting them. (LP:
    #1180521)
  * Add a webbrowser-app.pot target to the build system and integrate
    with dh_translations. Also internationalize the desktop file and
    strings in C++ code.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 171
 -- Ubuntu daily release <email address hidden> Tue, 11 Jun 2013 05:03:08 +0000

Changed in webbrowser-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.