Mahara

Masquerading sessions report fails if database tables have prefix

Bug #1190186 reported by Kevin Rickis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Son Nguyen
Mahara 1.8.0
1.8
Fix Released
High
Son Nguyen
Mahara 1.8.0

Bug Description

In version 1.7.1 in the script 'admin/users/report.php' on line 165, the table name 'event_log' is not enclosed in {} and therefore fails if the system have been set up with a table prefix.

See original description
Kevin Rickis (rdx565)
description: updated
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hello Kevin,

Thanks for finding this bug. We'll fix it and will put it into the next minor release of 1.7.

Changed in mahara:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 1.7.2
Son Nguyen (ngson2000)
Changed in mahara:
assignee: Robert Lyon (robertl-9) → Son Nguyen (ngson2000)
Revision history for this message
Son Nguyen (ngson2000) wrote :

I have looked through the code and fixed all occurrences of not using brackets () or {}.

Here is the patch https://reviews.mahara.org/2276 for master

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2276
Committed: http://gitorious.org/mahara/mahara/commit/b44eb79c482afe8008dce1d9e167faeaf700c39f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b44eb79c482afe8008dce1d9e167faeaf700c39f
Author: Son Nguyen <email address hidden>
Date: Fri Jun 14 09:37:13 2013 +1200

Fix not using brackets for table name (Bug #1190186)

Change-Id: I1b6048b2029f5964cf6ee96f6a44de5d5c4c3aaa
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Triaged → Fix Committed
status: Fix Committed → Triaged
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2283
Committed: http://gitorious.org/mahara/mahara/commit/6a625c364f631f1f4596e489354d3264c78584b2
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.7_STABLE

commit 6a625c364f631f1f4596e489354d3264c78584b2
Author: Robert Lyon <email address hidden>
Date: Mon Jun 24 09:41:19 2013 +1200

Fix not using brackets for table name (Bug #1190186)

Adding in needed changes to branch 1.7_STABLE

Change-Id: Ibb78c9f3964935c4ce29e3be69132013efa66d8c
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Triaged → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.7.2 → 1.8.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.