Ubuntu UI Toolkit

Panel.animating doesn't return to "false"

Bug #1199550 reported by Michał Sawicz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Bug introduced in rev 600

Given the snippet below:

import QtQuick 2.0
import Ubuntu.Components 0.1

Item {
    id: dashBar
    width: units.gu(80)
    height: units.gu(80)

    Panel {
        id: panel
        objectName: "panel"
        anchors {
            fill: parent
            topMargin: units.gu(60)
        }

        onAnimatingChanged: console.log(animating)

        Rectangle {
            color: "black"
            anchors.fill: parent

        }
    }
}

Panel.animating does not get reset to false.

The reason is comparing to 0.0 fails.

Related branches

lp:~fboucault/ubuntu-ui-toolkit/fix_panel_animating_value
PS Jenkins bot: Approve (continuous-integration)
Michał Sawicz: Approve
Diff: 34 lines (+6/-1)
1 file modified
modules/Ubuntu/Components/Panel.qml (+6/-1)
lp:ubuntu/saucy-proposed/ubuntu-ui-toolkit
lp:ubuntu/saucy/ubuntu-ui-toolkit
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit at revision 601, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+13.10.20130710-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+13.10.20130710-0ubuntu1) saucy; urgency=low

  [ Kaleo ]
  * Add a CrossFadeImage component which crossfades when its source is
    updated.
  * Standard animation durations adapted for new design: - SnapDuration
    goes from 125ms to 100ms - FastDuration goes from 250ms to 165ms -
    new BriskDuration is introduced at 333ms.
  * GIconProvider: avoid using QPixmap which is not re-entrant. Fixes
    crashes. (LP: #1197784)
  * Fine tuned UbuntuAnimation.StandardEasing to match design.
    Introduced new standard Ubuntu easing
    UbuntuAnimation.StandardEasingReverse.
  * Panel.animating: do not rely on comparing real values that sometimes
    have rounding errors. (LP: #1199550)

  [ Iain Lane ]
  * Add a CrossFadeImage component which crossfades when its source is
    updated.

  [ Loïc Molinari ]
  * [UbuntuShape] Moved content flagging before implicit sizing to
    prevent assertion.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 602
 -- Ubuntu daily release <email address hidden> Wed, 10 Jul 2013 06:11:45 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Revision history for this message
Michael Zanetti (mzanetti) wrote :

This fix (http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/revision/601) is just a workaround for the real issue being reported here:

https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1199662

Florian Boucault (fboucault)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.