Add patch for letting users of a QML ListView specify the delegate creation range

Bug #1217924 reported by Albert Astals Cid
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtdeclarative-opensource-src (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

By defaeult a QML ItemViews create items from contentY to contentY+height (with some buffering before and after). This is problematic when you embed an ItemView inside an ItemView (like we do in the dash) because you may end up with lots more of delegates instantiated than needed.

This patch adds two properties to the QML ItemViews letting a user decided if he wants to provide a range for delegate creation.

It comes with unit tests that show how only the needed items are being created instead of the full item view height.

After discussing this with the Qt Project QtQuick maintainer at the Qt Contributor Summit he rejected the idea to add this new feature in upstream Qt he decided to reject the idea as it was adding more feature cruft to classes that he wants rewritten. The rewrrite of those classes would also add this functionality so we are "safe" in this regard.

The patch need reviewing. I will be adding some Qt knowledgeable people to have a look.

More info at https://bugreports.qt-project.org/browse/QTBUG-32338 and https://codereview.qt-project.org/#change,60809

Tags: patch

Related branches

Revision history for this message
Albert Astals Cid (aacid) wrote :
Revision history for this message
Albert Astals Cid (aacid) wrote :

Michael/Gerry/Michał, could you please review the patch?

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "The said patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Michał Sawicz (saviq) wrote :
Changed in qtdeclarative-opensource-src (Ubuntu):
status: New → Incomplete
status: Incomplete → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtdeclarative-opensource-src - 5.0.2-6ubuntu2

---------------
qtdeclarative-opensource-src (5.0.2-6ubuntu2) saucy; urgency=low

  * Add qtquick_delegate_creation_range_itemviews.patch to patchset.
    (LP: #1217924)
 -- Michal Sawicz <email address hidden> Wed, 11 Sep 2013 14:03:31 +0200

Changed in qtdeclarative-opensource-src (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.