problem in aprove leave

Bug #1218036 reported by Adam Saadeh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Human Resources - Next Generation for OpenERP
Fix Committed
Low
Michael Telahun Makonnen

Bug Description

The following problem is not solved by the enhanced HR system:
If I define two employees A and B, where A is the head of the department and define as the manager of employee B. Now when B ask for a leave then his manager A can not approve it. Actually it is not appear at all in screens of A. One solution is to define A as an officer {HR Officer}. But this is not a solution becuase he then will see all the leaves request from any employee even those work in other departments.

So what is the solution for this bug

Tags: approve leave

Related branches

Adam Saadeh (emmad2000)
information type: Private Security → Public
Revision history for this message
Michael Telahun Makonnen (mmakonnen) wrote :

The OpenERP documentation says this is possible, but looking at the code I don't see how that is possible. For any one to approve a leave he/she must be defined as an HR Officer. If I am in error and I have broken some functionality I will do my best to fix it. Otherwise, since the organizations that I am currently working with don't need this kind of functionality, this is pretty low on my list of priorities to fix.

Changed in addons-hr-ng:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Michael Telahun Makonnen (mmakonnen)
Revision history for this message
Adam Saadeh (emmad2000) wrote :

Thanks Michael. I think based on my experience that the above functionality is very important. It is nice to have in your modules. I will explain why:
The manager of the department is the person who manage all the issues of his department. Suppose that he plan to do some tasks in the next days [seminars, submit proposals, finished tasks] and he needs all his employees to be with him. Then he will refuse to give any one a leave for example for the next days.
Instead of doing this manually, why do not give him the privilege to do this through the system.
In the past we asked the employee to assign the form of the leave from his manager. We can do the same by the computer through th HR system.
So I think the system should record the approve [or descion] of the manager together with a short explanation why he took this descion.

But what about if we have a list of a managers over that employee then what we should do: one solution is to give a default case for example just to have approve from the dirct manager and also give the flixibility to specify what level of managers the approve should be taken.
Any way, I think that functionality should be added.
Note that in the original hr modules from openerp this is bug even that in their documents they said that their system worked in the way I mentioned above.

As another thing that I did not check in your modules: If one of the HR officers ask for a leave then who will approve it for him [Can he appove it for him self]

Thanks again

Revision history for this message
Adam Saadeh (emmad2000) wrote : Re: [Bug 1218036] Re: problem in aprove leave
Download full text (3.2 KiB)

Thanks Michael. I think based on my experience that the above functionality is very important. It is nice to have in your modules. I will explain why:
The manager of the department is the person who manage all the issues of his department. Suppose that he plan to do some tasks in the next days [seminars, submit proposals, finished tasks] and he needs all his employees to be with him. Then he will refuse to give any one a leave for example for the next days.
Instead of doing this manually, why do not give him the privilege to do this through the system.
In the past we asked the employee to assign the form of the leave from his manager. We can do the same by the computer through th HR system.
So I think the system should record the approve [or descion] of the manager together with a short explanation why he took this descion.

But what about if we have a list of a managers over that employee then what we should do: one solution is to give a default case for example just to have approve from the dirct manager and also give the flixibility to specify what level of managers the approve should be taken.
Any way, I think that functionality should be added.
Note that in the original hr modules from openerp this is bug even that in their documents they said that their system worked in the way I mentioned above.

As another thing that I did not check in your modules: If one of the HR officers ask for a leave then who will approve it for him [Can he appove it for him self]

Thanks again

________________________________
 From: Michael Telahun Makonnen <email address hidden>
To: <email address hidden>
Sent: Thursday, August 29, 2013 12:31 PM
Subject: [Bug 1218036] Re: problem in aprove leave

The OpenERP documentation says this is possible, but looking at the code
I don't see how that is possible. For any one to approve a leave he/she
must be defined as an HR Officer. If I am in error and I have broken
some functionality I will do my best to fix it.  Otherwise, since the
organizations that I am currently working with don't need this kind of
functionality, this is pretty low on my list of priorities to fix.

** Changed in: addons-hr-ng
       Status: New => Confirmed

** Changed in: addons-hr-ng
   Importance: Undecided => Low

** Changed in: addons-hr-ng
     Assignee: (unassigned) => Michael Telahun Makonnen (mmakonnen)

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1218036

Title:
  problem in aprove leave

Status in Full Featured HR Modules for OpenERP:
  Confirmed

Bug description:
  The following problem is not solved by the enhanced HR system:
  If I define two employees A and B, where A is the head of the department and define as the manager of employee B. Now when B ask for a leave then his manager A can not approve it. Actually it is not appear at all in screens of A. One solution is to define A as an officer {HR Officer}. But this is not a solution becuase he then will see all the leaves request from any employee even those work in other departments.

  So what is the solution for this bug

To manage notifications about this bug go to:
https://bugs.launchpad.net...

Read more...

Changed in addons-hr-ng:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.