Mahara

Elasticsearch plugin not removing deleted groups

Bug #1225821 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 1.8.0

Bug Description

The Elasticsearch search plugin is not filtering out deleted groups, either during initial indexing or during subsequent updates. This is because, rather than deleting items from the group table, we use a group.deleted flag, and ElasticsearchType_group doesn't respect that flag.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

https://reviews.mahara.org/2497

Revision history for this message
Aaron Wells (u-aaronw) wrote :

From looking at the code, I noticed the same problem was likely to occur for forum posts, which also use a "deleted" flag rather than true deletion. The "usr" table also uses a deleted flag, but the code was already fully respecting it.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2497
Committed: http://gitorious.org/mahara/mahara/commit/203f3473c83cdecc7d7f3e0de56f99ff1a3679ee
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 203f3473c83cdecc7d7f3e0de56f99ff1a3679ee
Author: Aaron Wells <email address hidden>
Date: Mon Sep 16 12:57:27 2013 +1200

Elasticsearch: Respect "deleted" flags on elasticsearch indexed data

Bug 1225821: These elasticsearch types weren't respecting the
"deleted" flag on their source table:
- group
- interaction_forum_post
- interaction_instance

Change-Id: I39d0b0c83db2384875753113b51b94cf1c29d304

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.