Ubuntu
signon-ui package

facebook login page shouldn't suggest installing iphone app

Bug #1235259 reported by Ken VanDine
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Online Accounts: Sign-on UI
Fix Committed
Medium
Ken VanDine
signon-ui (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Our useragent is leading to facebook login suggesting installing the iphone app. Until we can merge the branch using the Browser component from the SDK, we should update the webview to use the same useragent logic.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: signon-ui 0.15+13.10.20131003.1-0ubuntu1
ProcVersionSignature: Ubuntu 3.11.0-9.16-generic 3.11.2
Uname: Linux 3.11.0-9-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.12.5-0ubuntu1
Architecture: amd64
Date: Fri Oct 4 09:16:52 2013
InstallationDate: Installed on 2011-02-24 (952 days ago)
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha amd64 (20110223)
MarkForUpload: True
SourcePackage: signon-ui
UpgradeStatus: Upgraded to saucy on 2013-06-03 (122 days ago)

Related branches

lp:~ken-vandine/signon-ui/lp1235259
PS Jenkins bot (community): Approve (continuous-integration)
Alberto Mardegan (community): Approve
Diff: 382 lines (+272/-74)
5 files modified
src/browser-process/UserAgent.qml (+90/-0)
src/browser-process/browser-process.pro (+3/-1)
src/browser-process/qml.qrc (+8/-7)
src/browser-process/ua-overrides.js (+99/-0)
src/browser-process/webview.qml (+72/-66)
lp:~mardy/signon-ui/lp1235259
Rejected for merging into lp:signon-ui
PS Jenkins bot (community): Approve (continuous-integration)
Online Accounts: Pending requested
Diff: 286 lines (+207/-15)
6 files modified
src/browser-process/UserAgent.qml (+90/-0)
src/browser-process/browser-process.pro (+3/-1)
src/browser-process/qml.qrc (+2/-0)
src/browser-process/ua-overrides.js (+105/-0)
src/browser-process/webview.qml (+5/-13)
src/request.cpp (+2/-1)
Revision history for this message
Ken VanDine (ken-vandine) wrote :
Changed in signon-ui:
assignee: nobody → Ken VanDine (ken-vandine)
importance: Undecided → Medium
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:signon-ui at revision 111, scheduled for release in signon-ui, milestone 0.12

Changed in signon-ui:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package signon-ui - 0.15+13.10.20131011-0ubuntu1

---------------
signon-ui (0.15+13.10.20131011-0ubuntu1) saucy; urgency=low

  [ Ken VanDine ]
  * Use a MainView and pull in the UserAgent logic used in the Browser
    component. Using the correct useragent fixes things like facebook
    suggesting users should install the facebook app for iphone (LP:
    #1235259). (LP: #1235259)
  * Allow overriding the QML files used by placing them in
    /usr/share/signon-ui/qml If there is a webview.qml file in that
    directory, load it instead of using the one built into the
    resources. This is useful for debugging QML only changes on the
    device without needing to rebuild and install signon-ui. It is
    important to note, when overriding them you need to copy include the
    .qml and .js files into that directory. .

  [ Iain Lane ]
  * Allow LIBDIR and LIBEXECDIR to be overridden; install in multiarch
    path; set LIBEXECDIR=LIBDIR .

  [ Alberto Mardegan ]
  * Bump build dependency for XEmbed support .
  * Allow the request to be cancelled from the UI. Clients can provide a
    QML component to be used in order to create the authentication page,
    and this gives them a way to add a cancel button there. (LP:
    #1231691)
  * Let the client override the Page component. . (LP: #1231691)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 115
 -- Ubuntu daily release <email address hidden> Fri, 11 Oct 2013 04:33:07 +0000

Changed in signon-ui (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.