Mahara

"Image gallery" block: switching between "Site files" and "My files" closes block config

Bug #1236122 reported by Aaron Wells
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Critical
Robert Lyon
Mahara 1.8.0

Bug Description

To replicate:

1. Create a page
2. Drag an "Image Gallery" block onto the page
3. In the block's configure pop-up, click the "Site files" tab
4. Now, click back to the "My files" tab.

Expected result: Should show the "My files" tab's content
Actual result: It closes the block's config pop-up

Tags: slideshow
Revision history for this message
Aaron Wells (u-aaronw) wrote :

I've verified that it's a regression. The behavior works fine in 1.7.3.

Revision history for this message
Robert Lyon (robertl-9) wrote :

Have added the fix for this as part of this patch:
https://reviews.mahara.org/#/c/2579/

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2579
Committed: http://gitorious.org/mahara/mahara/commit/2d855e68254839c5695959497ff6e377a8fd0c74
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 2d855e68254839c5695959497ff6e377a8fd0c74
Author: Robert Lyon <email address hidden>
Date: Mon Oct 7 12:49:58 2013 +1300

Problems with image gallery and file/folder selection
Bug 123530 and Bug 1236122

When js slideshow was chosen on a page without a slideshow block
(eg a new page) the js code returned by the selection was not loaded
fast enough

- I've altered it so the js is loaded on opening of config block

- Also folder was not staying selected when re-editing the block
due to it being not ArtefactTypeFile - have adjusted the check to
include ArtefactTypeFolder as well

- The switching between My files and Site files was breaking due to
folder artefact chooser not having certain elements on the page that the
js was trying to access. Have made it so js checks for elements before
trying to update them.

Change-Id: I9b8cbe786b0d35109f05a664f04665e9a9967d92
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
tags: removed: regression
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.