Ubuntu
qtubuntu package

Apps that close themselves crash trying to use deleted EGL resources

Bug #1237052 reported by Alexandros Frantzis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtubuntu (Ubuntu)
Fix Released
Undecided
Alexandros Frantzis

Bug Description

When an app is trying to close itself (e.g. the gallery app in pick mode), it gets into a situation where deleted EGL resources are used, leading to a crash.

To easily reproduce run the attached QML app with:

phablet@ubuntu-phablet:~$ /usr/lib/arm-linux-gnueabihf/qt5/bin/qmlscene close.qml --desktop_file_hint=gallery-app

See original description

Related branches

lp:~afrantzis/qtubuntu/fix-1237052
Michał Sawicz: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 90 lines (+18/-7)
4 files modified
src/platforms/base/window.cc (+12/-4)
src/platforms/base/window.h (+2/-1)
src/platforms/ubuntu/ubuntucommon/window.cc (+2/-1)
src/platforms/ubuntulegacy/window.cc (+2/-1)
lp:ubuntu/saucy-proposed/qtubuntu
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Investigation has led to qtubuntu being identified as the culprit. I am working on a fix.

Changed in qtubuntu:
status: New → In Progress
description: updated
kevin gunn (kgunn72)
Changed in qtubuntu:
status: In Progress → Fix Committed
Revision history for this message
Loïc Minier (lool) wrote :

I still get a crash with testcase after updating to mir + platform-api + unity-mir from PPA and qtubuntu from PPA which has this commit.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtubuntu - 0.52+13.10.20131009-0ubuntu1

---------------
qtubuntu (0.52+13.10.20131009-0ubuntu1) saucy; urgency=low

  [ Alexandros Frantzis ]
  * Release the EGL window surface before releasing the attached native
    window Otherwise, if the native window is released first, as was
    previously happening, the EGL platform may try to access the freed
    native window, leading to memory errors and crashes. (LP: #1237052)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 186
 -- Ubuntu daily release <email address hidden> Wed, 09 Oct 2013 20:27:39 +0000

Changed in qtubuntu (Ubuntu):
status: New → Fix Released
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

I also still get a crash with the branch lp:~afrantzis/qtubuntu/fix-1237052 and https://code.launchpad.net/~afrantzis/platform-api/fix-1236225 installed on maguro with version_detail: ubuntu=20131009.1,device=20131009.1,version=89

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

I don't have a maguro to check, but on mako with latest packages from the archive the crash is fixed. Loïc did you try on maguro or mako?

The exact package versions I have are:
qtubuntu-android 0.52+13.10.20131009-0ubuntu1
libubuntu-application-api-mirclient1 0.19+13.10.20131009.2-0ubuntu1
libmirserver6/libmirclient3 0.0.14+13.10.20131010-0ubuntu1
libunity-mir1 0.1+13.10.20131009.3-0ubuntu2
unity8 7.82+13.10.20131008.1-0ubuntu1

Revision history for this message
Loïc Minier (lool) wrote :

So I've retested with image #90, and it's now passing for me. I must have had some missing updates in my image when first trying this yesterday; I definitely had updated qtubuntu and had updated mir stack to some intermediate version, not sure what I was missing, but it works now and that's great!

Revision history for this message
Loïc Minier (lool) wrote :

(And this was on mako)

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

I am not seeing this today on channel_target: saucy-proposed version_detail: ubuntu=20131010.1,device=20131010,version=91 with maguro

Alexandros Frantzis (afrantzis)
Changed in qtubuntu:
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
Changed in qtubuntu (Ubuntu):
assignee: nobody → Alexandros Frantzis (afrantzis)
no longer affects: qtubuntu
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.