Ubuntu
ipkungfu package

ipkungfu script uses wrong shell instructions

Bug #126106 reported by Max Ischenko
2
Affects Status Importance Assigned to Milestone
ipkungfu (Ubuntu)
Fix Released
Undecided
Marco Rodrigues

Bug Description

Script /etc/init.d/ipkungfu is /bin/sh and it uses for example echo -ne and that's bash stuff.

See original description
Marco Rodrigues (gothicx)
Changed in ipkungfu:
assignee: nobody → gothicx
status: New → In Progress
Revision history for this message
Marco Rodrigues (gothicx) wrote :

It's fixed on Gutsy package... version: 0.6.1-4

https://launchpad.net/ubuntu/+source/ipkungfu/0.6.1-4

Changed in ipkungfu:
status: In Progress → Fix Released
Revision history for this message
Marco Rodrigues (gothicx) wrote :

I found the problem at script /etc/init.d/ipkungfu, it's still /bin/sh and not /bin/bash

Changed in ipkungfu:
status: Fix Released → In Progress
description: updated
Marco Rodrigues (gothicx)
Changed in ipkungfu:
assignee: gothicx → nobody
status: In Progress → Confirmed
Revision history for this message
Marco Rodrigues (gothicx) wrote :

I've also sent an e-mail to upstream author about this. I hope it will be fixed in the next version...

Marco Rodrigues (gothicx)
description: updated
Revision history for this message
Daniel Holbach (dholbach) wrote :

Why do you also change:
 - debian/compat
 - bump Depends and Build-Depends
 - change unrelated comments in the init script?

Is the 'echo -ne' issue the only one?

Changed in ipkungfu:
status: Confirmed → Incomplete
Revision history for this message
Marco Rodrigues (gothicx) wrote :

For now, it's the only change. I've contacted the author to fix it upstream and he says it will be fixed in a next release. So I set this bug to Invalid, because doesn't justify to make a new package just to fix this.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

From Rocco Stanzione (author):

"Will do, thanks. There won't be a new release for this of course, but it will be in the next release."

Revision history for this message
Daniel Holbach (dholbach) wrote :

Marco: I'm happy to do an upload for this fix.

Why did you also change these in the debdiff:
 - debian/compat
 - bump Depends and Build-Depends
 - change unrelated comments in the init script?

Revision history for this message
Marco Rodrigues (gothicx) wrote :

I do that changes because of needing of update the package for the future (>= gutsy), but it also works in feisty.
I update debian/compat to version 5, because that's what we usually use for gutsy packages and iptables for the version currently uses on feisty. The comment I change only because of the aspect.. lol

It's better to have "in Bug #315074" than "in # Bug#315074".

If you want, you can remove it from debdiff the bump of iptables and the comment.

Thanks!

Revision history for this message
Daniel Holbach (dholbach) wrote :

The problem is that we will have to merge these changes with every merge of Debian, so it's best to keep the diff small - especially if it does not serve a certain purpose.

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Ah ok! :-) Can you change the debdiff to remove the stuff that isn't needed ? after that you can upload it.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Can you do it?

Revision history for this message
Marco Rodrigues (gothicx) wrote :

Yes :-)

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks a lot! Uploaded!

Changed in ipkungfu:
assignee: nobody → gothicx
status: Incomplete → Fix Committed
Revision history for this message
Marco Rodrigues (gothicx) wrote :

ipkungfu (0.6.1-4ubuntu1) gutsy; urgency=low

  * Fixed debian/init.d script to use only /bin/sh instructions. (LP: #126106)

 -- Marco Rodrigues <email address hidden> Sun, 15 Jul 2007 11:18:09 +0100

Changed in ipkungfu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.