Mahara

Thumbnails style image galleries display incorrect

Bug #1266586 reported by Steven
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
1.10
Fix Released
High
Robert Lyon
Mahara 1.10.0
1.9
Fix Released
High
Robert Lyon
Mahara 1.9.3

Bug Description

How to Reproduce
-------------------------------
1. add a gallery to a profile page
2. select the the thumbnails style option
3. select the show descriptions check box
4. save the gallery

Result
--------------------
The gallery appears to be correct until a refresh of the page is done. The gallery will then overlap the images and descriptions and display a scroll bar to the right of the gallery.

Expected Result - would be for the gallery images & descriptions to be displayed without being overlapped

see attached screen shot for more details

Revision history for this message
Steven (stevens-q) wrote :
Revision history for this message
Aaron Wells (u-aaronw) wrote :

I'm able to replicate this issue sporadically, and it's not limited to Profile pages, but can happen on any page. It seems to happen if the width of the images in the gallery is wider than the space the layout makes available for its column.

Changed in mahara:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Happens to others as well.

https://mahara.org/interaction/forum/topic.php?id=6390

Changed in mahara:
importance: Low → High
milestone: none → 1.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3514

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3515

Revision history for this message
Howard Miller (howardsmiller) wrote :

Is there any progress on this. When might this be released?

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The fix for master, i.e. 1.10 is still in progress and needs to be verified. There are two patches for this:

https://reviews.mahara.org/3514
https://reviews.mahara.org/3515

You are welcome to test those on your instance and help us verify them. Patch 3515 needs to be re-fixed. Once they are done, we'll backport them and they will then be release in a minor point release.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3515
Committed: http://gitorious.org/mahara/mahara/commit/eaf104d84d0f9e9f1a18baec38b59f78b438522c
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit eaf104d84d0f9e9f1a18baec38b59f78b438522c
Author: Robert Lyon <email address hidden>
Date: Mon Jul 28 10:32:09 2014 +1200

Getting the max height from the img files correctly (Bug #1266586)

Problem existed where the cache didn't know the height of the files as
they had not been loaded before so the getting of the hightest one was
failing.

Changed it so that mahara passes in the height of the file to allow it
to fetch that instead.

Change-Id: I0a2cd8d316544cce65da73c1a7787759d5d6706d
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.10.0 → none
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3514
Committed: http://gitorious.org/mahara/mahara/commit/d1d5149841a122bdcc158d8655c046e159551de0
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.9_STABLE

commit d1d5149841a122bdcc158d8655c046e159551de0
Author: Robert Lyon <email address hidden>
Date: Mon Jul 28 10:06:47 2014 +1200

Getting the max height from the img files correctly (Bug #1266586)

Problem existed where the cache didn't know the height of the files as
they had not been loaded before so the getting of the hightest one was
failing.

Changed it so that mahara passes in the height of the file to allow it
to fetch that instead.

Change-Id: I765ee00bd05720e8643ee97976a097d9cf394211
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.