Odoo Addons (MOVED TO GITHUB)

[7.0+trunk] Fullscreen mode for pads is broken

Bug #1267108 reported by Richard Mathot (Odoo, formerly OpenERP)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Addons Team 1

Bug Description

The fullscreen mode of the pads is broken; it seems to interfere with the chatter.

Steps to reproduce the bug:
- Go to Project > Tasks
- Open a task and switch to edit mode
- The field "description" is a pad
- Click on the "fullscreen" icon of the pad

Results observed:
The pad takes the whole window of the browser, BUT the chatter window is still on the screen.

Results expected:
The pad should enlarge up to the full width and height of the browser window, the chatter should be hidden.

(tested on trunk r9038)

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-1267108-avo
Rejected for merging into lp:openobject-addons
OpenERP Core Team: Pending requested
Diff: 13 lines (+3/-0)
1 file modified
pad/static/src/js/pad.js (+3/-0)
lp:openobject-addons/7.0
lp:ocb-addons
lp:~ocb/ocb-addons/rs-ocb-70
Revision history for this message
Richard Mathot (Odoo, formerly OpenERP) (rim-openerp) wrote :
Twinkle Christian(OpenERP) (tch-openerp)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Christophe Simonis (OpenERP) (kangol) wrote :

Also in 7.0

summary: - [trunk] Fullscreen mode for pads is broken
+ [7.0+trunk] Fullscreen mode for pads is broken
Revision history for this message
Amit Vora(OpenERP) (amit.vora-openerp) wrote :

Hello,
              I have fixed inhttps://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1267108-avo
              Revision ID: <email address hidden>
              Revision No:9066

Thanks,
avo.

Changed in openobject-addons:
status: Confirmed → In Progress
status: In Progress → Fix Committed
Revision history for this message
Richard Mathot (Odoo, formerly OpenERP) (rim-openerp) wrote :

avo,

It seems your fix breaks the pads elsewhere, they cannot be displayed anymore.

Traceback (most recent call last):
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/http.py", line 321, in dispatch
    response["result"] = self._call_function(**self.params)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/http.py", line 194, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/service/model.py", line 112, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/http.py", line 189, in checked_call
    return self.func(*a, **kw)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/addons/web/controllers/main.py", line 1109, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/addons/web/controllers/main.py", line 1101, in _call_kw
    return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/addons/pad/pad.py", line 43, in pad_generate_url
    myPad.createPad(path)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/addons/pad/py_etherpad/__init__.py", line 208, in createPad
    return self.call("createPad", params)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/addons/pad/py_etherpad/__init__.py", line 50, in call
    return self.handleResult(result)
  File "/home/odoo/runbot/static/openerp-dev-trunk-bug-1267108-avo-28746/server/openerp/addons/pad/py_etherpad/__init__.py", line 65, in handleResult
    raise ValueError(result['message'])
ValueError: padID did not match requirements

Changed in openobject-addons:
status: Fix Committed → In Progress
Revision history for this message
Christophe Simonis (OpenERP) (kangol) wrote :

fixed in 7.0 by revid 9832 <email address hidden>

Changed in openobject-addons:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.