Mahara

Skins form needs to use label elements

Bug #1273937 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
Mahara 1.9.0

Bug Description

Child of Bug #1259756

Currently the form to add/edit a skin has labels for most elements, but since they do not use the <label> tag they are not accessible to screen reader users.
Also, the direction pickers (for background position etc.) need hidden labels.

Affects latest master

(WCAG Level A)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/2973

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2973
Committed: http://gitorious.org/mahara/mahara/commit/2401c8844492b7c5e7cd51db3c79e3187bd1edea
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 2401c8844492b7c5e7cd51db3c79e3187bd1edea
Author: Jono Mingard <email address hidden>
Date: Wed Jan 29 16:51:43 2014 +1300

Use <label> tags in skin designer (Bug #1273937)

Changed 'labelhtml' to 'title' in skin design form to allow the input
labels to use the <label> tag and therefore be accessible to screen
readers.
Modified the position choosers to have hidden labels and (hopefully)
fixed cross-browser inconsistencies in the layout.
Also modified the structure of the radio pieforms element to fix issues
with screen readers.

Change-Id: I8706c34e2c2a86b0f3d54b5f0c54d337ecc251a6
Signed-off-by: Jono Mingard <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.