Some parts of Buildmaster code are not covered by tests
Bug #129487 reported by
Celso Providelo
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Michael Nelson | ||
Bug Description
Parts of the 'buildmaster' library are completely untested, specially BuilderGroup.
Related branches
lp:~michael.nelson/launchpad/550049-overwriting-buildd-manager-files-2
- Michael Nelson (community): Approve (code)
- Julian Edwards (community): Approve
-
Diff: 239 lines (+121/-31)3 files modifiedlib/lp/buildmaster/model/buildbase.py (+38/-23)
lib/lp/buildmaster/tests/test_buildbase.py (+74/-4)
lib/lp/soyuz/tests/soyuzbuilddhelpers.py (+9/-4)
| Changed in soyuz: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| Changed in soyuz: | |
| assignee: | nobody → cprov |
| Changed in soyuz: | |
| milestone: | 1.1.12 → 1.2.1 |
| Changed in soyuz: | |
| milestone: | 1.2.1 → 1.2.2 |
| Changed in soyuz: | |
| milestone: | 1.2.2 → none |
| tags: | added: tech-debt |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #1 |
| Changed in soyuz: | |
| assignee: | Celso Providelo (cprov) → Michael Nelson (michael.nelson) |
| status: | Triaged → In Progress |
| milestone: | none → 10.04 |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Linking a branch that adds basic test coverage for buildStatus_OK. Now that we've factored out a number of things (such as getUploaderCommand) we can stub it with a fake method to test everything in buildStatus_OK outside of the actual upload.