pdebuild overrides --buildresult

 affects /ubuntu/pbuilder

pdebuild is meant to take pbuilder options after a --, according to the
help.

e.g.

pdebuild -- --buildresult /path/to/dir

and for most options, this works - e.g.
pdebuild -- --basetgz my-base.tgz

however, one option in particular does not work this way - --buildresult

if you do
pdebuild -- --buildresult /path/to/dir, then the parser in
/usr/lib/pbuilder/pdebuild-checkparams will see there is no
--buildresult in the pdebuild specific options, which leads to
BUILDRESULT="" being exported, this then is passed onto the pbuilder
command explicitly, *after* the supplied --buildresult, overriding it.

Changing this line in /usr/bin/pdebuild
    ${PBUILDERROOTCMD} ${PDEBUILD_PBUILDER} --build "$@" ${EXTRA_CONFIGFILE[@]/#/--configfile } --buildresult "${BUILDRESULT}" --debbuildopts "${DEBBUILDOPTS}" ../"${PKG_SOURCENAME}_${PKG_VERSION}".dsc

To

    ${PBUILDERROOTCMD} ${PDEBUILD_PBUILDER} --build --buildresult "${BUILDRESULT}" "$@" ${EXTRA_CONFIGFILE[@]/#/--configfile } --debbuildopts "${DEBBUILDOPTS}" ../"${PKG_SOURCENAME}_${PKG_VERSION}".dsc

Fixes it for me.

That is - move the --buildresult option before the "$@". Moving "$@" to
the end of the line would avoid all possible cases of that, but I
haven't thought deeply enough about the implications to predict side
effects.

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.