This patch implements some improvements to notification settings which will also allow us to more easily implement further features. Included in this patch:
- Each activity type can specify a default notification method. They default to 'email' to remain backwards compatible.
- Each activity type can specify if it is allowed to be set to 'none'. Defaults to 'allowed' for backwards compatibility.
- Removed 'required' from notification settings - it didn't make sense, and the change above deals with this in a better way.
- The site wide defaults for each activity type can be edited in Site options -> Notification settings. These are applied to new users or whenever a user does not have the appropriate usr_activity_preference records.
- There is a separate help next to each activity type to explain what messages will be affected by the setting.
The following additional changes were made internally to allow the above:
- Most activity types can now be set to 'none'. We feel that only user to user and system messages should be enforeced and everything else should be optional.
- The way 'none' is handled was changed. A missing usr_activity_preference record indicates that the settings has not yet been set, so the default should be user. Null method indicates 'none' was selected.
- The function pieform_get_help was modified to check for element fields 'helpplugintype', 'helppluginname' and 'helpformname' so that the notification settings form elements could be reused in the site options. (We want to use the same help files on more than one form, but the help files are saved with the form name, so we had to allow the form name to be specified for the help).
Activity type plugin authors should be aware of the following changes:
- 'enablenonemethod' and 'defaultmethod' are values that can be specified when specifying an activity type. Both are optional.
- Help files can be specified for each activity type. The help files can be placed in the plugin's subfolder (e.g. artefact/myplugin/lang/...). Help files are optional, but should be provided, otherwise "There was no help found for this item." will be displayed.
Version: master
Patch for "master" branch: https:/