feature request: bookmark behaviour

Am Freitag, den 03.08.2007, 20:04 +0000 schrieb arthurv:
> Public bug reported:
>
> 0.18
>
> adding bookmarks not available through File menu
>
> right-clicking a folder in the right hand pane brings a menu that has
> "bookmark" at the bottom, but when you click this the current directory
> is bookmarked, not the folder you right-clicked.
>
> if I have time I'll try to fix this myself, but I won't complain if it
> gets fixed sooner :)

  status triaged
  importance wishlist
  tags +olive

Cheers,

Jelmer

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

In current trunk there is an option 'Bookmark current folder' so half the work is done..
With respect to the context menu..
It can be implemented, but in different ways.
-The OliveMenu class generating the menu items knows the selected item so before creating the self.actiongroup.add_actions is invoked, there could be some if os.path.isdir(self.selected): magic (if selected gets a string from the event that is. Didn't check.) to pick between the strings 'Bookmark current folder' and 'Bookmark this folder'. The current 'Bookmark' is ambiguous anyway.
- Or leave that ambiguous 'Bookmark' and do the smart stuff behind the screens in the OliveMenu.bookmark method. E.g. a 'if os.path.isdir(self.selected): path = self.selected, else: path = self.path, followed by the self.pref.add_bookmark(path)
Or as a matter of fact.. we could do both. :)