lshw doesn't deal w/ device-tree endianness

Bug #1308760 reported by dann frazier
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lshw
Unknown
Unknown
lshw (Debian)
Fix Released
Unknown
lshw (Ubuntu)
Fix Released
Medium
Brian Murray
Trusty
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
lshw parses /proc/device-tree to read system properties on device-tree-based platforms. But, on little endian systems like armhf and arm64, it doesn't properly convert the data, which should always be big endian. This can cause incorrect data to be reported. For instance, a 1GHz cpu might be reported as 13MHz because lshw reads a frequency of 0xca9a3b (13MHz) instead of 0x3b9aca00 (1GHz).
[Test Case]
Run lshw on an HP m800 cartridge and examine the cpu frequency.
[Regression Potential]
We're changing parsing code, so there's a possibility that we break that code on systems that currently work in trusty. I tested on a big endian system to make sure it didn't break things there (powerpc), and found the output to be byte-for-byte identical before and after the patch.

Related branches

Revision history for this message
Thomas Palmer (thomas-palmer-n) wrote :

project owner has emailed me and said an update was checked into subversion. I will check out new subversion code and give it a try

Revision history for this message
Thomas Palmer (thomas-palmer-n) wrote :

lshw project owner accepted my patch. Please pull latest from project git/svn

dann frazier (dannf)
description: updated
Changed in lshw (Debian):
status: Unknown → New
Changed in lshw (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Changed in lshw (Ubuntu):
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lshw - 02.16-2ubuntu2

---------------
lshw (02.16-2ubuntu2) utopic; urgency=medium

  * Fix endianness issues with device-tree (LP: #1308760)
  * Add DDR3 support for systems described by device-tree (LP: #1351921)
 -- dann frazier <email address hidden> Sun, 03 Aug 2014 14:54:54 +0200

Changed in lshw (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello dann, or anyone else affected,

Accepted lshw into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lshw/02.16-2ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lshw (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
dann frazier (dannf) wrote :
dann frazier (dannf)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lshw - 02.16-2ubuntu1.1

---------------
lshw (02.16-2ubuntu1.1) trusty-proposed; urgency=medium

  * Fix endianness issues with device-tree (LP: #1308760)
  * Add DDR3 support for systems described by device-tree (LP: #1351921)
 -- dann frazier <email address hidden> Thu, 16 Oct 2014 16:26:33 -0600

Changed in lshw (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for lshw has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in lshw (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.