When stopping a node from the web UI that was started from the API, distro_series is not cleared
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Julian Edwards | ||
1.5 |
Fix Released
|
Critical
|
Julian Edwards | ||
maas (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Test Case]
1. Install MAAS
2. Add a node.
3. Deploy the node
4. When you destroy a node, distro_series will remain with the selected distro_series.
With the fix:
4. When you destroy a node, distro_series will be cleared.
I'm not sure how I got into this state, but one of my nodes that's unallocated has a valid value in its distro_series field. This means that when you start it up from the web UI next time it will now ignore the global default and always use that series because of the logic in Node.get_
At the very least, Node.release() should call set_distro_
UPDATE:
It had been originally started with the API (which sets the passed distro series) but released with the web UI.
Related branches
- Jeroen T. Vermeulen (community): Approve
-
Diff: 41 lines (+8/-1)3 files modifiedsrc/maasserver/api.py (+0/-1)
src/maasserver/models/node.py (+1/-0)
src/maasserver/models/tests/test_node.py (+7/-0)
- Julian Edwards (community): Approve
-
Diff: 41 lines (+8/-1)3 files modifiedsrc/maasserver/api.py (+0/-1)
src/maasserver/models/node.py (+1/-0)
src/maasserver/models/tests/test_node.py (+7/-0)
Changed in maas: | |
status: | New → Triaged |
importance: | Undecided → Critical |
assignee: | nobody → Julian Edwards (julian-edwards) |
summary: |
- When stopping a node from the web UI, distro_series is not cleared + When stopping a node from the web UI that was started from the API, + distro_series is not cleared |
description: | updated |
Changed in maas: | |
status: | Triaged → Fix Committed |
description: | updated |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Changed in maas (Ubuntu): | |
status: | New → Fix Released |
tags: |
added: verification-done removed: verification-needed |
Hello Julian, or anyone else affected,
Accepted maas into trusty-proposed. The package will build now and be available at http:// launchpad. net/ubuntu/ +source/ maas/1. 5.1+bzr2269- 0ubuntu0. 1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!