Segfaults when using symlinks

Bug #132391 reported by Sebastian Heinlein
4
Affects Status Importance Assigned to Milestone
bzr-builddeb (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: bzr-builddeb

As soon as I add a relative symlink to my bzr branch, bd command does not work anymore:

renate@renate-laptop:ubuntu$ bzr bd -w
Running in split mode
Building using working tree
Preparing the build area: ../build-area
bzr: ERROR: exceptions.TypeError: coercing to Unicode: need string or buffer, NoneType found

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 729, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 691, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 389, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/builddeb/__init__.py", line 265, in run
    build.export(use_existing)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/builddeb/builder.py", line 338, in export
    export(tree,source_dir,None,None)
  File "/usr/lib/python2.5/site-packages/bzrlib/export/__init__.py", line 95, in export
    return _exporters[format](tree, dest, root)
  File "/usr/lib/python2.5/site-packages/bzrlib/export/__init__.py", line 61, in _loader
    return func(tree, dest, root)
  File "/usr/lib/python2.5/site-packages/bzrlib/export/dir_exporter.py", line 47, in dir_exporter
    ie.put_on_disk(dest, dp, tree)
  File "/usr/lib/python2.5/site-packages/bzrlib/inventory.py", line 325, in put_on_disk
    self._put_on_disk(fullpath, tree)
  File "/usr/lib/python2.5/site-packages/bzrlib/inventory.py", line 807, in _put_on_disk
    os.symlink(self.symlink_target, fullpath)
TypeError: coercing to Unicode: need string or buffer, NoneType found

bzr 0.18.0 on python 2.5.1.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'bd', '-w']

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 132391] Segfaults when using symlinks

On (14/08/07 08:36), Sebastian Heinlein wrote:
> Public bug reported:
>
> Binary package hint: bzr-builddeb
>
> As soon as I add a relative symlink to my bzr branch, bd command does
> not work anymore:

Ah, sorry about this.

It seems to me that if you commit then you will be able to build is that
correct?

If so then I believe the bug is in bzrlib, but it is not an operation that
is exposed by bzr, so they wouldn't have hit it.

I'm away for the weekend, but I will look in to it next week. The
problem is that at first glance I can't really see what is going on in
bzrlib here, but hopefully one of the devs can help me out.

Hopefully the workaround of committing will help you out. I know it's
not ideal, so hopefully we can sort it soon.

Thanks,

James

--
  James Westby -- GPG Key ID: B577FE13 -- http://jameswestby.net/
  seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256

Revision history for this message
Reinhard Tartler (siretart) wrote :

bzr-builddeb (0.90ubuntu1) gutsy; urgency=low

  * upload to gutsy. Verified it still works with bzr 0.18
  * Complete the transition of deb822 into python-debian. LP: #134607

bzr-builddeb (0.90) unstable; urgency=low

  * Support exporting the working tree when it contains symlinks. Thanks
    to John Arbash Meinel for help on fixing it. (LP: #132391)
  * Fix the repacking of .tar.bz2 file to .tar.gz. Thanks Frederic Brin.
  * Complete the transition of deb822 into python-debian.

 -- Reinhard Tartler <email address hidden> Sat, 08 Sep 2007 23:14:30 +0200

Changed in bzr-builddeb:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.