[Security] UPNP opens port 0 which fully exposes PC to the internet.

Bug #1330703 reported by leigh123linux
258
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libtorrent-rasterbar (Ubuntu)
Fix Released
High
Andrew Starr-Bochicchio
Trusty
Fix Released
High
Andrew Starr-Bochicchio

Bug Description

Building libtorrent against boost-1.54 leaves it vulnerable to this UPNP issue.
Basically libtorrent upnp opens port 0 (wildcard port so the router forwards all unmapped ports to the given IP) on the router leaving open to attack.

https://github.com/qbittorrent/qBittorrent/issues/1758

I have applied this to all feddora branches and recommend you do the same.

http://pkgs.fedoraproject.org/cgit/rb_libtorrent.git/plain/rb_libtorrent-0.16.8-upnp_remove_port0..patch?h=f19

Revision history for this message
Seth Arnold (seth-arnold) wrote :

Thanks for taking the time to report this bug and helping to make Ubuntu better. Since the package referred to in this bug is in universe or multiverse, it is community maintained. If you are able, I suggest coordinating with upstream and posting a debdiff for this issue. When a debdiff is available, members of the security team will review it and publish the package. See the following link for more information: https://wiki.ubuntu.com/SecurityTeam/UpdateProcedures

Changed in libtorrent-rasterbar (Ubuntu):
status: New → Incomplete
Revision history for this message
Seth Arnold (seth-arnold) wrote :

Nice debugging; thanks for the patch. Do you know if a CVE has been assigned yet?

Thanks

information type: Private Security → Public Security
Revision history for this message
leigh123linux (leigh123linux-j) wrote :

Sorry no CVE has been filed as we don't know the procedure.
As for posing a debdiff do you have a guide on how to do this from Fedora?

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

So this looks like upstream commit 10001 and 10003:

https://code.google.com/p/libtorrent/source/detail?r=10001
https://code.google.com/p/libtorrent/source/detail?r=10003

Which were released in libtorrent-rasterbar-0.16.17.tar.gz

I'll get this into Debian sid and Ubuntu utopic shortly, and then kick off the SRU process for trusty.

Changed in libtorrent-rasterbar (Ubuntu):
status: Incomplete → In Progress
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
importance: Undecided → High
Changed in libtorrent-rasterbar (Ubuntu Trusty):
importance: Undecided → High
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libtorrent-rasterbar - 0.16.17-1ubuntu2

---------------
libtorrent-rasterbar (0.16.17-1ubuntu2) utopic; urgency=medium

  * Make sure repatch target is actually called.
  * Build against Boost 1.55.

libtorrent-rasterbar (0.16.17-1ubuntu1) utopic; urgency=medium

  * Reapply ppc64el delta.
   - Use dh-autoreconf for ppc64el.
   - Add repatch target to debian/rules to work around autoreconf
     regenerating the patched configure script.

libtorrent-rasterbar (0.16.17-1) unstable; urgency=medium

  * New upstream release.
   - Don't fall back on wildcard port in UPnP (LP: #1330703).
 -- Andrew Starr-Bochicchio <email address hidden> Sun, 22 Jun 2014 13:05:14 -0400

Changed in libtorrent-rasterbar (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
CSRedRat (csredrat) wrote :
Changed in libtorrent-rasterbar (Ubuntu Trusty):
status: Triaged → In Progress
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

ACK on the debdiff, thanks!

It is building now and will be released today.

Changed in libtorrent-rasterbar (Ubuntu Trusty):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libtorrent-rasterbar - 0.16.13-1ubuntu2.1

---------------
libtorrent-rasterbar (0.16.13-1ubuntu2.1) trusty-security; urgency=medium

  * SECURITY UPDATE: Stop UPnP from falling back on port 0. Routers
    may forward unmapped ports to the given IP, exposing the machine
    to the internet (LP: #1330703).
 -- Andrew Starr-Bochicchio <email address hidden> Mon, 23 Jun 2014 22:42:45 -0400

Changed in libtorrent-rasterbar (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.