ReadOnlyError when using tag for bzr viz
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar GTK+ Frontends |
Triaged
|
Medium
|
Unassigned |
Bug Description
I get a ReadOnlyError when I use the tag function form bzr viz, but *not* when in the log window in olive-gtk.
Steps to reproduce:
* Run bzr viz
* Right click on a revision, click on tag revision.
* Enter tag name.
* Click Add Tag
Expected result:
* Tag added.
Actual Result:
* The following error is written to the console, and the tag is not added:
Traceback (most recent call last):
File bzrlib/
self.
File bzrlib/branch.py, line 1304, in lock_write
repo_token = self.repository
File bzrlib/
result = self.control_
File bzrlib/
raise errors.
bzrlib.
Hi
The attached patch fixes Bug #133220: ReadOnlyError when using tag for
bzr viz. What the patch does is just before we create a write lock, we
check if there is a read lock. If there is, unlock it, and then create
to read lock afterwards.
Please can the be merged into the trunk?
Gary