[TOPBLOCKER] [Dash] [design] Preview images display as black thumbnails

Bug #1333187 reported by Michał Karnicki
28
This bug affects 3 people
Affects Status Importance Assigned to Milestone
The Savilerow project
Fix Released
Critical
Unassigned
Ubuntu UX
Fix Released
High
Jouni Helminen
unity8 (Ubuntu)
Fix Released
Critical
Andrea Cimitan
unity8 (Ubuntu RTM)
Fix Released
Critical
Andrea Cimitan

Bug Description

If the image is large, the Ubuntu shape rounded corners become very little, hardly noticable.

REQUESTED UX SOLUTION
Updated spec so images only zoomable once full screen.

For all other instances of ubuntu shape, SDK documentation should be used (see link from Jouni in comments)

Related branches

Michał Karnicki (karni)
tags: added: scope-dev
Revision history for this message
Michał Sawicz (saviq) wrote :

This happens for the zoomable image, because it gets scaled down to fit, while the corners are rounded at 1:1 scale...

Not sure how to solve this design-wise, we probably don't want to round the corners "after" scaling, maybe we simply need to always apply the same corner radius...

Changed in ubuntu-ux:
assignee: nobody → Mike Nagle (mikenagle)
Revision history for this message
Mike Nagle (mikenagle) wrote :

I'm reliably informed that there's two or three corner radius' available that depend on image size. I recommend checking the SDK documentation or asking Jouni for more details

Changed in ubuntu-ux:
assignee: Mike Nagle (mikenagle) → Jouni Helminen (jounihelminen)
status: New → Triaged
Revision history for this message
Jouni Helminen (jounihelminen) wrote :

http://developer.ubuntu.com/api/devel/ubuntu-13.04/qml/ui-toolkit/qml-ubuntu-components0-ubuntushape.html

Let me know if the medium radius property is still too small, and we can look at adding another one that's larger

Revision history for this message
Michał Sawicz (saviq) wrote :

It's not about setting the radius. The problem is this is a *zoomable* image (well, it can be, isn't by default).

Which means you can take two fingers and use that to zoom the image in and out. What that means (currently) is the shape radius/highlight/shadow is zoomed with it. We need a UX+visual solution for the zoomable use case, please.

Revision history for this message
Michał Sawicz (saviq) wrote :

The spec https://sites.google.com/a/canonical.com/unity8dash/toolkit/14-previews has been updated with:

    Tapping on image opens it full screen
    Image can then be scrolled or zoomed (via pinch and spread)
    Used for product images and artwork that requires zoom
    Can contain optional credit below video. Left aligned. "Credit: Lorem ipsum dolor" where credit text can be a link to the source

Changed in unity8:
status: New → Incomplete
status: Incomplete → Triaged
importance: Undecided → High
Changed in ubuntu-ux:
status: Triaged → Fix Committed
Revision history for this message
Mike Nagle (mikenagle) wrote :

Spec is updated:

Tapping on image opens it full screen
Image can then be scrolled or zoomed (via pinch and spread)
Used for product images and artwork that requires zoom
Can contain optional credit below video. Left aligned. "Credit: Lorem ipsum dolor" where credit text can be a link to the source

Think that solves the issue?

Changed in ubuntu-ux:
assignee: Jouni Helminen (jounihelminen) → Mike Nagle (mikenagle)
description: updated
Revision history for this message
Michał Karnicki (karni) wrote :

E-mailed Jouni regarding this bug. Can't assign him, not sure if he has an lp account.

Revision history for this message
Michał Karnicki (karni) wrote :

Ignore my last comment, I must have not refreshed the page.

Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
importance: Undecided → High
status: New → Triaged
Changed in ubuntu-ux:
assignee: Mike Nagle (mikenagle) → nobody
assignee: nobody → Giorgio Venturi (giorgio-venturi)
status: Fix Committed → Triaged
summary: - Preview image rounded corners depend on image size
+ [sdk] Preview image rounded corners depend on image size
John Lea (johnlea)
Changed in ubuntu-ux:
importance: Undecided → High
Changed in ubuntu-ux:
assignee: Giorgio Venturi (giorgio-venturi) → nobody
assignee: nobody → Jouni Helminen (jounihelminen)
Michał Sawicz (saviq)
no longer affects: unity8
Michał Sawicz (saviq)
summary: - [sdk] Preview image rounded corners depend on image size
+ Preview image rounded corners depend on image size
Michał Sawicz (saviq)
summary: - Preview image rounded corners depend on image size
+ Preview images should not be scaled down but open fullscreen, just as
+ gallery does
tags: added: rtm14
Changed in unity8 (Ubuntu):
importance: High → Critical
Changed in savilerow:
importance: Undecided → Critical
Revision history for this message
Joe Odukoya (jodukoya) wrote : Re: Preview images should not be scaled down but open fullscreen, just as gallery does

Raising this to Critical as fixing this is required in order to fix bug no 1377965 (which is a critical bug).

John Lea (johnlea)
summary: - Preview images should not be scaled down but open fullscreen, just as
- gallery does
+ [Dash] Preview images should not be scaled down but open fullscreen,
+ just as gallery does
kevin gunn (kgunn72)
summary: - [Dash] Preview images should not be scaled down but open fullscreen,
- just as gallery does
+ [Dash] [design] Preview images should not be scaled down but open
+ fullscreen, just as gallery does
summary: - [Dash] [design] Preview images should not be scaled down but open
- fullscreen, just as gallery does
+ [Dash] [design] Preview images display as black thumbnails
tags: added: touch-2014-10-23
kevin gunn (kgunn72)
Changed in ubuntu-ux:
status: Triaged → Fix Committed
Revision history for this message
kevin gunn (kgunn72) wrote : Re: [Dash] [design] Preview images display as black thumbnails

@saviq - just assigning so it doesn't get lost, since pat seems to request it make the next flight 10/23
also, not totally sure we have everything we need from design ?

Changed in unity8 (Ubuntu):
assignee: nobody → Michał Sawicz (saviq)
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: Michał Sawicz (saviq) → Andrea Cimitan (cimi)
Andrea Cimitan (cimi)
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
kevin gunn (kgunn72)
tags: added: touch-2014-10-30
removed: touch-2014-10-23
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu RTM):
importance: Undecided → Critical
status: New → In Progress
assignee: nobody → Andrea Cimitan (cimi)
summary: - [Dash] [design] Preview images display as black thumbnails
+ [TOPBLOCKER] [Dash] [design] Preview images display as black thumbnails
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.01+15.04.20141030~rtm-0ubuntu1

---------------
unity8 (8.01+15.04.20141030~rtm-0ubuntu1) 14.09; urgency=medium

  [ Michael Terry ]
  * Provide 'passphrase' as a field of Components.Lockscreen
  * Fix a race between Qml loading and DBus registration that caused
    problems when jenkins tried to unlock the phone.
  * Set domain explicitly for the Dialogs component because the welcome
    wizard wants to import it. (LP: #1381731)
  * When greeter or lockscreen has focus, show active call panel. (LP:
    #1378872)

  [ Ted Gould ]
  * Set the default OOM score for the dash (LP: #1379786)

  [ Michał Sawicz ]
  * Revert lp:~unity-team/unity8/flickables-speed-workaround to avoid
    risk in RTM.
  * Updated behaviour for zoomable image, workaround for sourcesize (LP:
    #1333187)

  [ Michael Frey ]
  * Added a check for Proximity to determine if we show the lock screen.
    (LP: #1378012)

  [ Ying-Chun Liu ]
  * Add non-interactive code into GenericScopeView. (LP: #1384441)

  [ Mirco Müller ]
  * Also use modal nature of snap-decision notifications when
    greeter/lockscreen is shown. This fixes LP: #1378827. (LP: #1378827)

  [ Michael Zanetti ]
  * Make the launcher update on dconf changes (LP: #1376707)
  * exit spread on background tap (LP: #1368261)
  * Use an index instead of a scope id in DashCommunicator (LP:
    #1376044)

  [ Andrea Cimitan ]
  * Updated behaviour for zoomable image, workaround for sourcesize (LP:
    #1333187)

  [ Daniel d'Andrada ]
  * Make TouchGate synthesize QMouseEvents for mouse-based target items
  * Don't specify a distanceThreshold as it conflicts with
    hintDisplacment
 -- Ubuntu daily release <email address hidden> Thu, 30 Oct 2014 21:43:42 +0000

Changed in unity8 (Ubuntu RTM):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.01+15.04.20141030-0ubuntu1

---------------
unity8 (8.01+15.04.20141030-0ubuntu1) vivid; urgency=medium

  [ Michael Terry ]
  * Provide 'passphrase' as a field of Components.Lockscreen
  * Fix a race between Qml loading and DBus registration that caused
    problems when jenkins tried to unlock the phone.
  * Set domain explicitly for the Dialogs component because the welcome
    wizard wants to import it. (LP: #1381731)
  * When greeter or lockscreen has focus, show active call panel. (LP:
    #1378872)

  [ Ted Gould ]
  * Set the default OOM score for the dash (LP: #1379786)

  [ Michał Sawicz ]
  * Revert lp:~unity-team/unity8/flickables-speed-workaround to avoid
    risk in RTM.
  * Updated behaviour for zoomable image, workaround for sourcesize (LP:
    #1333187)

  [ Michael Frey ]
  * Added a check for Proximity to determine if we show the lock screen.
    (LP: #1378012)

  [ Ying-Chun Liu ]
  * Add non-interactive code into GenericScopeView. (LP: #1384441)

  [ Mirco Müller ]
  * Also use modal nature of snap-decision notifications when
    greeter/lockscreen is shown. This fixes LP: #1378827. (LP: #1378827)

  [ Michael Zanetti ]
  * Make the launcher update on dconf changes (LP: #1376707)
  * exit spread on background tap (LP: #1368261)
  * Use an index instead of a scope id in DashCommunicator (LP:
    #1376044)

  [ Andrea Cimitan ]
  * Updated behaviour for zoomable image, workaround for sourcesize (LP:
    #1333187)

  [ Daniel d'Andrada ]
  * Make TouchGate synthesize QMouseEvents for mouse-based target items
  * Don't specify a distanceThreshold as it conflicts with
    hintDisplacment
 -- Ubuntu daily release <email address hidden> Thu, 30 Oct 2014 21:43:42 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Chris Wayne (cwayne)
Changed in savilerow:
status: New → Fix Released
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.