Add support for Dell PowerEdge 13G servers

Debdiff for trusty

Utopic Debdiff

Hello Kent,

thank you for spending your time helping to make Ubuntu better with this bug report.

I think that the upstream patch must be tested first on a real 13G and then take over into upstream.

Jörg Frings-Fürst
ipmitool Maintainer

Jörg,

To be clear, Kent works for Canonical and with Dell directly, and I can see that the patch has been written by Dell. I presume that Dell and Kent have tested it. I see that the patch affects ipmi_delloem.{c,h} only, and in addition it looks like the only thing it does is handle 13G in the same way that other known hardware is handled - no feature changes at all.

This looks like a prime hardware enablement candidate to cherry-pick and maintain in Ubuntu until new releases have caught up, so that Dell 13G is supported well in Ubuntu as soon as it is available. It's also a candidate for a Trusty SRU as it's purely a hardware enablement patch.

I would prefer to see the patch land upstream first, so that we can be more confident that Ubuntu doesn't accidentally diverge and that we can drop the patch with the next ipmitool release. And an upstream release would be even better. But as Dell want the support in time for Utopic and assuming that they have tested it, I propose that we accept the patch in Ubuntu and maintain the delta until a new release filters through. Do you have any objection to this?

Alternatively, you can take the patch in Debian if you want it, and Ubuntu can sync.

Yes, I have done some testing on new generation as well as current generation systems with the patch, with emphasis on the delloem commands, since that's what the patches touch the most. Everything seems to be working fine on both sets of hardware.

I'm fine with whatever direction ulitmately gets taken, but, keep in mind that the initial 13G rollout will be very soon (without giving away too much).

Thanks for all your help!

Ok, Thanks for your answers.

Has somebody called the upstream maintainer?

CU
Jörg

On Sat, Jul 19, 2014 at 03:23:23PM -0000, Jörg Frings-Fürst wrote:
> Has somebody called the upstream maintainer?

Yes - as Kent stated in his original report, a patch has been submitted
upstream, so upstream, Debian and any other distribution can include the
same support at their leisure:
http://sourceforge.net/p/ipmitool/patches/102/

I plan to review this patch for inclusion directly in Ubuntu today.

Uploaded to Utopic with some minor review changes as discussed with Kent on IRC (#ubuntu-devel) just now. Trusty upload pending bug SRU information.

Updated description with required SRU fields. Please let me know if I need to add anything else. Thanks for your help, Robie!

This bug was fixed in the package ipmitool - 1.8.14-3ubuntu1

---------------
ipmitool (1.8.14-3ubuntu1) utopic; urgency=medium

  * debian/patches/113_add-support-for-Dell-PowerEdge-13G.patch: add support
    for Dell PowerEdge 13G (LP: #1343407)
 -- Kent Baxley <email address hidden> Thu, 17 Jul 2014 12:23:27 -0500

Uploaded to trusty-proposed with minor changes:

1. Dropped Standards-Version bump.

2. Amended version number to match version scheme in https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

3. Moved patch to end of debian/patches/series (it still applies there)

4. Amended patch dep-3 headers to match Utopic upload (as discussed with Kent previously)

Now awaiting SRU team review. Thanks Kent!

Hello Kent, or anyone else affected,

Accepted ipmitool into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ipmitool/1.8.13-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Tested on Dell Hardware, paying particular attention to existing 12G systems so that nothing 'broke' with the update. Looking good.

To clarify further this was tested on 13G hardware as well as 12G. My mention of 12G was to ensure that there were no regressions with existing hardware. 13G hardware is also working fine with the patched package.

This bug was fixed in the package ipmitool - 1.8.13-1ubuntu0.1

---------------
ipmitool (1.8.13-1ubuntu0.1) trusty; urgency=low

  * debian/patches/113_add-support-for-Dell-PowerEdge-13G.patch: Add support
    for Dell PowerEdge 13G (LP: #1343407)
 -- Kent Baxley <email address hidden> Thu, 17 Jul 2014 11:00:26 -0500

The verification of the Stable Release Update for ipmitool has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.