Stellarium

Framerate decreases if importing mpc data

Bug #1350418 reported by Claus
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stellarium
Fix Released
High
gzotti
Stellarium 0.13.1

Bug Description

The framerate decreased drastically (100fps --> 5 fps) if I import mpc data (e.g. all observable comets).
Clicking on default settings will cure the problem, however.

Tested on two computers (desktop with core i7, ATI 7950 and Laptop with core i5, Intel HD4600) both on Windows 7_x64 with the latest drivers for the video cards.

best regards
Claus

Related branches

lp:~stellarium/stellarium/comet-speedup
Alexander Wolf: Approve (code)
Fabien Chéreau: Pending requested
Diff: 810 lines (+293/-132)
9 files modified
plugins/SolarSystemEditor/src/SolarSystemEditor.cpp (+16/-3)
src/core/modules/Comet.cpp (+166/-74)
src/core/modules/Comet.hpp (+26/-10)
src/core/modules/MinorPlanet.cpp (+41/-18)
src/core/modules/MinorPlanet.hpp (+3/-2)
src/core/modules/Orbit.hpp (+1/-1)
src/core/modules/Planet.cpp (+32/-22)
src/core/modules/Planet.hpp (+2/-2)
src/core/modules/SolarSystem.cpp (+6/-0)
Revision history for this message
Claus (sualci) wrote :

I forgot to mention :
Stellarium version 0.13

Alexander Wolf (alexwolf)
Changed in stellarium:
status: New → Confirmed
Alexander Wolf (alexwolf)
Changed in stellarium:
importance: Undecided → High
Revision history for this message
gzotti (georg-zotti) wrote :

Hmm, something I never had expected, I had expected observers just selected 5-10 really interesting comets.

Importing "all" means about 730 comets. All of them have orbit_good=1000 (i.e. orbits, tails etc are computed for perihel date +/- 1000 days). This may indeed be too much, with computation of 1460 rotated tail parabola.

As short workaround: can you please edit your ssystem.ini in a regular text editor and replace all strings "orbit_good=1000" with "orbit_good=100". This should at least reduce the number of periodic comets.

Else, for now please reset your ssystem.ini and download only a handful of comet elements.

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Georg, can you test it: lp:~stellarium/stellarium/planets-bounding-cap ?

I tested with big ssystem.ini file (http://astro.uni-altai.ru/~aw/stellarium/ssystem.ini.tgz) and get around 8 FPS (without patch I have around 4 FPS on this file).

Revision history for this message
Claus (sualci) wrote :

Georg,
edited ssystem.ini as you suggested but without an effect (framerate stays low).

BTW:
I had no problems to import all comets on version 0.12.4

Revision history for this message
gzotti (georg-zotti) wrote :

@Alex: Sorry, not before weekend.

@Claus: 0.12.4 did not have coment tails, just positions. It's considerably more computation.

Please then delete the comets you don't need. Keep the 20 most needed, not 730. This situation should be improvable in the next release.

gzotti (georg-zotti)
Changed in stellarium:
milestone: none → 0.13.1
gzotti (georg-zotti)
Changed in stellarium:
status: Confirmed → In Progress
assignee: nobody → gzotti (georg-zotti)
Revision history for this message
Alexander Wolf (alexwolf) wrote :

Diff: http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/6953

Changed in stellarium:
status: In Progress → Fix Committed
Alexander Wolf (alexwolf)
Changed in stellarium:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.