flash-kernel should not consider ignored kernels as latest

the suggested patch just filters the selection of 'latest' through the whitelist.

After applying smoser's changes to proposed version of flash-kernel, flash-kernel is able to generate a boot.scr for keystone2

+ basename /usr/sbin/flash-kernel
+ self=flash-kernel
+ mktemp -dt flash-kernel.XXXXXXXX
+ tmpdir=/tmp/flash-kernel.YDX2TwaC
+ kernel=/boot/vmlinuz-3.13.0-9-keystone
+ initrd=/boot/initrd.img-3.13.0-9-keystone
+ [ -n ]
+ [ -n /boot/boot.scr ]
+ boot_script_path=//boot/boot.scr
+ boot_script=/usr/share/flash-kernel/bootscript/bootscr.keystone2
+ mkimage_script 0x0 boot script /usr/share/flash-kernel/bootscript/bootscr.keystone2 /tmp/flash-kernel.YDX2TwaC/boot.scr
+ local saddr=0x0
+ local sdesc=boot script
+ local sdata=/usr/share/flash-kernel/bootscript/bootscr.keystone2
+ local script=/tmp/flash-kernel.YDX2TwaC/boot.scr
+ basename /usr/share/flash-kernel/bootscript/bootscr.keystone2
+ local tdata=/tmp/flash-kernel.YDX2TwaC/bootscr.keystone2
+ mktemp --tmpdir=/tmp/flash-kernel.YDX2TwaC
+ local ubootenv=/tmp/flash-kernel.YDX2TwaC/tmp.roGZAJGKP2
+ gen_ubootenv
+ ENVSTUBDIRS=/etc/flash-kernel/ubootenv.d /usr/share/flash-kernel/ubootenv.d
+ LC_ALL=C+ sortfind -u
 /etc/flash-kernel/ubootenv.d /usr/share/flash-kernel/ubootenv.d -type f -regex .*/[0-9a-zA-Z_-]+ -printf %f\n
+ ENVSTUBS=
+ printf Generating boot script u-boot image...
Generating boot script u-boot image... + sed -e /@@UBOOT_ENV_EXTRA@@/{
  s/@@UBOOT_ENV_EXTRA@@//g
  r /tmp/flash-kernel.YDX2TwaC/tmp.roGZAJGKP2
  }
+ mkimage -A arm -O linux -T script -C none -a 0x0 -e 0x0 -n boot script -d /tmp/flash-kernel.YDX2TwaC/bootscr.keystone2 /tmp/flash-kernel.YDX2TwaC/boot.scr
+ echo done.
done.
+ boot_script=/tmp/flash-kernel.YDX2TwaC/boot.scr
+ backup_and_install /tmp/flash-kernel.YDX2TwaC/boot.scr //boot/boot.scr
+ local source=/tmp/flash-kernel.YDX2TwaC/boot.scr
+ local dest=//boot/boot.scr
+ [ -e //boot/boot.scr ]
+ basename //boot/boot.scr
+ echo Installing new boot.scr.
Installing new boot.scr.
+ mv /tmp/flash-kernel.YDX2TwaC/boot.scr //boot/boot.scr
+ cleanups
+ rm -rf /tmp/flash-kernel.YDX2TwaC
+ [ -d ]

This bug was fixed in the package flash-kernel - 3.0~rc.4ubuntu51

---------------
flash-kernel (3.0~rc.4ubuntu51) utopic; urgency=medium

  * Filter the selection of 'latest' usable kernel through the
    whitelist. (LP: #1356569)
 -- Manoj Iyer <email address hidden> Tue, 19 Aug 2014 14:27:33 -0500

Hello Scott, or anyone else affected,

Accepted flash-kernel into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/flash-kernel/3.0~rc.4ubuntu49.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I found a regression with the proposed package (3.0~rc.4ubuntu49.2) on APM Mustang systems:

ubuntu@am3:~$ sudo flash-kernel
[...]
+ [ machine = fields ]
+ read field value
+ [ machine = machine ]
+ [ = Machine: ]
+ [ machine = fields ]
+ read field value
+ [ machine = machine ]
+ [ ## = Machine: ]
+ [ machine = fields ]
+ read field value
+ [ machine = machine ]
+ [ Machine: = Machine: ]
+ [ Foundation-v8A = APM X-Gene Mustang board ]
+ [ machine = fields ]
+ read field value
+ return 1
+ kflavors=
ubuntu@am3:~$ echo $?
1

Pushed a fix to fix the regression. With the new fix:

root@lazy:/# flash-kernel
flash-kernel: installing version 3.13.0-35-generic
Generating kernel u-boot image... done.
Installing new uImage.
Generating initramfs u-boot image... done.
Installing new uInitrd.
Generating boot script u-boot image... done.
Installing new boot.scr.
root@lazy:/# ls /boot
abi-3.13.0-35-generic System.map-3.13.0-35-generic
boot.scr uImage
config-3.13.0-35-generic uInitrd
grub vmlinuz-3.13.0-35-generic
initrd.img-3.13.0-35-generic
root@lazy:/# dd if=/boot/boot.scr skip=1 bs=72 of=/tmp/bootscript
2+1 records in
2+1 records out
173 bytes (173 B) copied, 0.005532 s, 31.3 kB/s
root@lazy:/# cat /tmp/bootscript
setenv bootargs 'console=ttyS0,9600n8r ro'

load scsi 0 ${kernel_addr_r} uImage
load scsi 0 ${ramdisk_addr_r} uInitrd
bootm ${kernel_addr_r} ${ramdisk_addr_r} ${fdt_addr_r}
root@lazy:/# cat /proc/device-tree/model
HP ProLiant m400 Server Cartridgeroot@lazy:/#

The fixed flash-kernel is in the upload queue.

Hello Scott, or anyone else affected,

Accepted flash-kernel into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/flash-kernel/3.0~rc.4ubuntu49.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

This fix was verified by me on mcdivitt and slayton and found to work reliably.

The change I tested was done by Scott Moser
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/flash-kernel/trusty-proposed/revision/472
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/utopic/flash-kernel/utopic/revision/472

which is different from the one proposed in the MP here.

Testing on McDivitt from -proposed.

ubuntu@ubuntu:~$ cat /proc/device-tree/model
HP ProLiant m400 Server Cartridge
ubuntu@ubuntu:~$

ubuntu@ubuntu:~$ apt-cache policy flash-kernel
flash-kernel:
  Installed: 3.0~rc.4ubuntu49.3
  Candidate: 3.0~rc.4ubuntu49.3
  Version table:
 *** 3.0~rc.4ubuntu49.3 0
        500 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main arm64 Packages

ubuntu@ubuntu:~$ sudo flash-kernel
sudo: unable to resolve host ubuntu
flash-kernel: installing version 3.13.0-35-generic
Generating kernel u-boot image... done.
Taking backup of uImage.
Installing new uImage.
Generating initramfs u-boot image... done.
Taking backup of uInitrd.
Installing new uInitrd.
Generating boot script u-boot image... done.
Taking backup of boot.scr.
Installing new boot.scr.
ubuntu@ubuntu:~$ ls -la /boot
total 95520
drwxr-xr-x+ 4 root root 4096 Sep 15 16:45 .
drwxr-xr-x+ 21 root root 4096 Sep 15 16:34 ..
-rw------- 1 root root 2563726 Aug 18 22:49 System.map-3.13.0-35-generic
-rw-r--r-- 1 root root 959590 Aug 18 22:49 abi-3.13.0-35-generic
-rw-rw-rw- 1 root root 245 Sep 15 16:45 boot.scr
-rw-rw-rw- 1 root root 245 Sep 11 16:09 boot.scr.bak
-rw-r--r-- 1 root root 119629 Aug 18 22:49 config-3.13.0-35-generic
drwxr-xr-x+ 2 root root 4096 Aug 26 16:27 grub
-rw-r--r-- 1 root root 22010243 Sep 11 16:09 initrd.img-3.13.0-35-generic
drwx------ 2 root root 16384 Sep 11 16:09 lost+found
-rw-rw-rw- 1 root root 9361408 Sep 15 16:45 uImage
-rw-rw-rw- 1 root root 9361408 Sep 11 16:09 uImage.bak
-rw-rw-rw- 1 root root 22010307 Sep 15 16:45 uInitrd
-rw-rw-rw- 1 root root 22010307 Sep 11 16:09 uInitrd.bak
-rw------- 1 root root 9361344 Aug 18 22:49 vmlinuz-3.13.0-35-generic
ubuntu@ubuntu:~$

Testing on Slayton with -proposed flash-kernel.
=======================================

ubuntu@ubuntu:~$ cat /proc/device-tree/model
HP ProLiant m800 Server Cartridge
ubuntu@ubuntu:~$

ubuntu@ubuntu:~$ apt-cache policy flash-kernel
flash-kernel:
  Installed: 3.0~rc.4ubuntu49.3
  Candidate: 3.0~rc.4ubuntu49.3
  Version table:
 *** 3.0~rc.4ubuntu49.3 0
        500 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main armhf Packages

ubuntu@ubuntu:~$ sudo flash-kernel
sudo: unable to resolve host ubuntu
flash-kernel: installing version 3.13.0-9-keystone
Generating boot script u-boot image... done.
Taking backup of boot.scr.
Installing new boot.scr.
ubuntu@ubuntu:~$

ubuntu@ubuntu:~$ ls -lh /boot
total 29M
-rw------- 1 root root 2.0M Aug 6 16:20 System.map-3.13.0-9-keystone
-rw-r--r-- 1 root root 1.1M Aug 6 16:20 abi-3.13.0-9-keystone
-rw-r--r-- 1 root root 261 Sep 15 16:50 boot.scr
-rw-r--r-- 1 root root 261 Sep 12 04:11 boot.scr.bak
-rw-r--r-- 1 root root 140K Aug 6 16:20 config-3.13.0-9-keystone
drwxr-xr-x 2 root root 4.0K Aug 15 00:36 grub
-rw-r--r-- 1 root root 21M Sep 12 04:11 initrd.img-3.13.0-9-keystone
-rw------- 1 root root 4.5M Aug 6 16:20 vmlinuz-3.13.0-9-keystone
ubuntu@ubuntu:~$

run-parts: executing /etc/kernel/postinst.d/x-grub-legacy-ec2 3.13.0-11-keystone /boot/vmlinuz-3.13.0-11-keystone
Searching for GRUB installation directory ... found: /boot/grub
Searching for default file ... found: /boot/grub/default
Testing for an existing GRUB menu.lst file ... found: /boot/grub/menu.lst
Searching for splash image ... none found, skipping ...
Ignoring non-Xen Kernel on Xen domU host: vmlinuz-3.13.0-11-keystone
Ignoring non-Xen Kernel on Xen domU host: vmlinuz-3.13.0-9-keystone
Updating /boot/grub/menu.lst ... done

ubuntu@ubuntu:~$ sudo apt-get install linux-keysone

<skipping some lines>

run-parts: executing /etc/kernel/postinst.d/zz-flash-kernel 3.13.0-11-keystone /boot/vmlinuz-3.13.0-11-keystone
flash-kernel: deferring update (trigger activated)
Setting up linux-headers-3.13.0-11-keystone (3.13.0-11.18) ...
Setting up linux-image-keystone (3.13.0.11.10) ...
Setting up linux-headers-keystone (3.13.0.11.10) ...
Setting up linux-keystone (3.13.0.11.10) ...
Processing triggers for flash-kernel (3.0~rc.4ubuntu49.3) ...
flash-kernel: installing version 3.13.0-11-keystone
Generating boot script u-boot image... done.
Taking backup of boot.scr.
Installing new boot.scr.
ubuntu@ubuntu:~$

flash-kernel should ignore linux-generic on slayton because slayton uses flavor kernel -keystone
==============================================================================
ubuntu@ubuntu:~$ sudo apt-get install linux-generic
run-parts: executing /etc/kernel/postinst.d/x-grub-legacy-ec2 3.13.0-36-generic /boot/vmlinuz-3.13.0-36-generic
Searching for GRUB installation directory ... found: /boot/grub
Searching for default file ... found: /boot/grub/default
Testing for an existing GRUB menu.lst file ... found: /boot/grub/menu.lst
Searching for splash image ... none found, skipping ...
Ignoring non-Xen Kernel on Xen domU host: vmlinuz-3.13.0-11-keystone
Ignoring non-Xen Kernel on Xen domU host: vmlinuz-3.13.0-9-keystone
Found kernel: /boot/v...

Testing on Slayton with -proposed flash-kernel
=======================================

Installing new kernel on slayton flash-kernel pickup linux-keystone and setup boot.scr correctly:

ubuntu@ubuntu:~$ sudo apt-get install linux-keystone
sudo: unable to resolve host ubuntu
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer required:
  linux-headers-3.13.0-33 linux-headers-3.13.0-33-generic-lpae
  linux-headers-generic-lpae
Use 'apt-get autoremove' to remove them.
The following extra packages will be installed:
  linux-headers-3.13.0-11-keystone linux-headers-keystone
  linux-image-3.13.0-11-keystone linux-image-keystone
Suggested packages:
  fdutils linux-keystone-doc-3.13.0 linux-keystone-source-3.13.0
  linux-keystone-tools
The following NEW packages will be installed:
  linux-headers-3.13.0-11-keystone linux-image-3.13.0-11-keystone
The following packages will be upgraded:
  linux-headers-keystone linux-image-keystone linux-keystone
3 upgraded, 2 newly installed, 0 to remove and 29 not upgraded.
Need to get 55.8 MB of archives.

< skipping some lines here >

update-initramfs: deferring update (hook will be called later)
Examining /etc/kernel/postinst.d.
run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 3.13.0-11-keystone /boot/vmlinuz-3.13.0-11-keystone
run-parts: executing /etc/kernel/postinst.d/initramfs-tools 3.13.0-11-keystone /boot/vmlinuz-3.13.0-11-keystone
update-initramfs: Generating /boot/initrd.img-3.13.0-11-keystone
run-parts: executing /etc/kernel/postinst.d/update-notifier 3.13.0-11-keystone /boot/vmlinuz-3.13.0-11-keystone
run-parts: executing /etc/kernel/postinst.d/x-grub-legacy-ec2 3.13.0-11-keystone /boot/vmlinuz-3.13.0-11-keystone
Searching for GRUB installation directory ... found: /boot/grub
Searching for default file ... found: /boot/grub/default
Testing for an existing GRUB menu.lst file ... found: /boot/grub/menu.lst
Searching for splash image ... none found, skipping ...
Ignoring non-Xen Kernel on Xen domU host: vmlinuz-3.13.0-11-keystone
Ignoring non-Xen Kernel on Xen domU host: vmlinuz-3.13.0-9-keystone
Updating /boot/grub/menu.lst ... done

run-parts: executing /etc/kernel/postinst.d/zz-flash-kernel 3.13.0-11-keystone /boot/vmlinuz-3.13.0-11-keystone
flash-kernel: deferring update (trigger activated)
Setting up linux-headers-3.13.0-11-keystone (3.13.0-11.18) ...
Setting up linux-image-keystone (3.13.0.11.10) ...
Setting up linux-headers-keystone (3.13.0.11.10) ...
Setting up linux-keystone (3.13.0.11.10) ...
Processing triggers for flash-kernel (3.0~rc.4ubuntu49.3) ...
flash-kernel: installing version 3.13.0-11-keystone
Generating boot script u-boot image... done.
Taking backup of boot.scr.
Installing new boot.scr.

ubuntu@ubuntu:~$ ls -lh /boot
total 87M
-rw------- 1 root root 2.0M Sep 4 10:24 System.map-3.13.0-11-keystone
-rw------- 1 root root 2.7M Sep 4 00:30 System.map-3.13.0-36-generic
-rw------- 1 root root 2.0M Aug 6 16:20 System.map-3.13.0-9-keystone
-rw-r--r-- 1 root root 1.1M Sep 4 10:24 abi-3.13.0-11-keystone
-rw-r--r-- 1 root root 1.1M Sep 4 00:30 abi-3.13.0-36-generic...

This bug was fixed in the package flash-kernel - 3.0~rc.4ubuntu49.3

---------------
flash-kernel (3.0~rc.4ubuntu49.3) trusty-proposed; urgency=medium

  * Do not fail if there are no specified Kernel-Flavors for this
    machine (LP: #1356569).
 -- Scott Moser <email address hidden> Tue, 02 Sep 2014 10:13:43 -0400

The verification of the Stable Release Update for flash-kernel has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.