Avoid query for existing artefact record when we know it's new.

Bug #1364687 reported by Nigel Cunningham
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Nigel Cunningham

Bug Description

When importing users from a CSV file, we can avoid the query for an existing artefact record when we know it doesn't exist (because we're being called from create_user). This shaves approximately 40% off the time for creating a user.

Tags: performance
Changed in mahara:
assignee: nobody → Nigel Cunningham (nigelc-g)
status: New → In Progress
Changed in mahara:
importance: Undecided → Medium
tags: added: performance
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3613
Committed: http://gitorious.org/mahara/mahara/commit/f0fd10e2c0c0be08c8a8cc2459f2f388d4c548d9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f0fd10e2c0c0be08c8a8cc2459f2f388d4c548d9
Author: Nigel Cunningham <email address hidden>
Date: Wed Aug 6 15:24:56 2014 +1000

(Bug 1364687) Don't look for an artefact record when we know we're making a new one.

Avoid the query for an existing artefact record when we know it doesn't
exist (because we're being called from create_user). This shaves
approximately 40% off the time for creating a user.

Change-Id: I81697dfd0916e4a2933dfe5d1389bdc649e6e856
Signed-off-by: Nigel Cunningham <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 15.04.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.