apport should gather package information about click packages

Bug #1365079 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Medium
Martin Pitt

Bug Description

Bug 1324853 was about there being a click command line switch for gathering information about a click package. This now exists and works:

click info /opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.blabble/current/blabble.qml

{
    "architecture": "all",
    "description": "Word search game",
    "framework": "ubuntu-sdk-14.10-qml-dev3",
    "hooks": {
        "blabble": {
            "apparmor": "blabble.json",
            "desktop": "blabble.desktop"
        }
    },
    "installed-size": "21615",
    "maintainer": "Jamie Strandboge <email address hidden>",
    "name": "com.ubuntu.developer.jdstrand.blabble",
    "title": "Blabble",
    "version": "0.5"
}

While the error tracker retracers will not be able to retrace these crashes, it would still be good if we could assign them to a package and include the package version.

Tags: utopic
Revision history for this message
Brian Murray (brian-murray) wrote :

It looks like this will require some changes to report.py's add_package_info and fileutils.py's find_file_package and likely_packaged.

tags: added: utopic
Revision history for this message
Brian Murray (brian-murray) wrote :

Here is an exampe of an incomplete report in the error tracker:

https://errors.ubuntu.com/oops/d4735084-2c76-11e4-acb3-fa163e75317b

Revision history for this message
Brian Murray (brian-murray) wrote :

To be clear that incomplete report is missing Package and SourcePackage information.

Revision history for this message
Brian Murray (brian-murray) wrote :

Actually, it's get_file_package of backends/packaging-apt-dpkg.py that would need some modification. Perhaps we could check and see if the path contains "/usr/share/click/preinstalled/" or "/opt/click.ubuntu.com/" before using the "click info" command.

Changed in apport (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

So far we never talked about click support in apport so far; a lot of concepts are quite different. E. g. they don't necessarily have an LP project, it does not necessarily coincide with the click name, don't have source packages, can't be retraced, don't have package dependencies.

So we need to invent some new fields and teach the error tracker about it. E. g. Click: and SystemImageVersion:, and it wouldn't have Package:/SourcePackage:/Dependencies. Pretty much nothing in backends/packaging-apt-dpkg.py applies to them, so they should rather get an entirely new backend, and we need to add support for having multiple ones instead of selecting one at build time.

Martin Pitt (pitti)
Changed in apport (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Brian Murray (brian-murray) wrote :

Martin and I discussed an interim solution for RTM / utopic. If I recall correctly, you mentioned creating a separate hook that would gather call "click info" and gather information about the package and its version. This separate hook would need to be called by the ubuntu hook. Does that sound right?

Revision history for this message
Martin Pitt (pitti) wrote :

> This separate hook would need to be called by the ubuntu hook.

No, it can and should just be placed into /usr/share/apport/general-hooks/, maybe "clickinfo.py". This avoids referring to that interim hack in the code or any other hooks, so that we can easily replace and test it.

Revision history for this message
Brian Murray (brian-murray) wrote :

Ah, I'd forgotten that all hooks in /usr/share/apport/general-hooks/ are run.

Revision history for this message
Brian Murray (brian-murray) wrote :

I've uploaded the interim solution to Vivid now. See this commit for the implementation:

http://bazaar.launchpad.net/~ubuntu-core-dev/ubuntu/vivid/apport/ubuntu/revision/2364

Revision history for this message
Brian Murray (brian-murray) wrote :

Here is a crash report from Vivid on a mako device:

https://errors.ubuntu.com/oops/d94a7b00-6376-11e4-8f2e-fa163e4ccdf2

Everything looks good.

Revision history for this message
Brian Murray (brian-murray) wrote :

However, its not possible to find these crashes in the Error Tracker frontend because they don't have a crash signature.

Revision history for this message
Martin Pitt (pitti) wrote :

Brian fixed that a while ago, thanks!

apport (2.14.7-0ubuntu9) vivid; urgency=medium

  * data/general_hooks/clickinfo.py: Created a hook to determine package
    and version information for executables that are from click packages.

 -- Brian Murray <email address hidden> Fri, 31 Oct 2014 14:41:14 -0700

Changed in apport (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.