webbrowser-app

Sometimes suggestions fail to appear

Bug #1365304 reported by Leo Arias
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
webbrowser-app
Fix Released
Medium
Olivier Tilloy
webbrowser-app (Ubuntu)
Fix Released
Undecided
Olivier Tilloy

Bug Description

The error message:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/webbrowser_app/tests/test_history.py", line 135, in test_suggestions_hidden_while_drawer_open
    self.assert_suggestions_eventually_shown()
  File "/usr/lib/python3/dist-packages/webbrowser_app/tests/test_history.py", line 77, in assert_suggestions_eventually_shown
    self.assertThat(suggestions.opacity, Eventually(Equals(1)))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: After 10.0 seconds test on Suggestions.opacity failed: 1 != dbus.Double(0.0, variant_level=1)

The link to the latest failure:
http://ci.ubuntu.com/smokeng/utopic/touch/mako/221:20140904:20140903.1/10199/webbrowser_app/1628626/

Related branches

lp:~osomon/webbrowser-app/improve-ap-test-robustness
PS Jenkins bot: Approve (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 13 lines (+1/-2)
1 file modified
tests/autopilot/webbrowser_app/tests/test_history.py (+1/-2)
lp:ubuntu/utopic/webbrowser-app
Revision history for this message
Leo Arias (elopio) wrote :

I'm not able to reproduce this on my RTM devices. Flashing devel-proposed on mako to try again.

Leo Arias (elopio)
summary: - test_suggestions_hidden_while_drawer_open is failing since mako #213
+ Sometimes suggestions fail to appear
Revision history for this message
Leo Arias (elopio) wrote :

This was hard to reproduce, but now I can do it on my mako, image #221. I just have to reboot.
So, reboot, then open webbrowser, then click the url bar, it will show the suggestions. Click the drawer, it will hide the suggestions. Click the bar again, it won't show the suggestions.

It just happens here the first time after reboot.

Łukasz Zemczak (sil2100)
tags: added: lt-category-noimpact lt-date-20140904 lt-prio-low
Revision history for this message
Olivier Tilloy (osomon) wrote :

I can’t reproduce on flo with image #243 (I don’t have a mako) with Leo’s instructions in comment #2.

Revision history for this message
Olivier Tilloy (osomon) wrote :

I think I know what might be happening: since http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/revision/692, the history model is loaded asynchronously at startup. The list of suggestions gets its data from the history model, so it might be that at when trying to display suggestions, the history model is not fully loaded yet. This would explain why it’s observed on mako only, which is a slower device than others which we use for testing.

I’ll confirm the bug and will try and find a way to make the autopilot test reliable. I don’t think it has a visible user impact though, so I’ll set its importance to medium.

Changed in webbrowser-app:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Olivier Tilloy (osomon)
Łukasz Zemczak (sil2100)
tags: added: lt-whitelisted
Revision history for this message
Olivier Tilloy (osomon) wrote :

I had misread the description, comment #4 doesn’t explain the issue: apparently the list of suggestions already appeared, then were hidden, and only then failed to appear again. So this can’t be explained by the asynchronous loading of the history model.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+14.10.20141003-0ubuntu1

---------------
webbrowser-app (0.23+14.10.20141003-0ubuntu1) utopic; urgency=low

  [ CI bot ]
  * Resync trunk

  [ Alexandre Abreu ]
  * Add a simple mechanism (simpler than the one already in place) to
    override user agents for a given webapp. (LP: #1370975)

  [ Alberto Mardegan ]
  * Fix handling of host cookies

  [ Olivier Tilloy ]
  * Ship a PNG icon instead of an SVG, and install it under the app’s
    own data dir. (LP: #1365408)
  * Make an autopilot test more robust by ensuring that the drawer menu
    is dismissed but not clicked. (LP: #1365304)
  * Persistently cache favicons on disk to avoid re-downloading them
    across application runs. (LP: #1340585)
  * Ensure that at most 2 webviews are instantiated at all times, to
    reduce memory consumption. (LP: #1376418)
 -- Ubuntu daily release <email address hidden> Fri, 03 Oct 2014 14:42:27 +0000

Changed in webbrowser-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Confirmed → Fix Released
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.