Ubuntu
qtmir package

Mir Motion event tool type on touch device is 0 (AMOTION_EVENT_TOOL_TYPE_UNKNOWN)

Bug #1371282 reported by Brandon Schaefer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtmir (Ubuntu)
Fix Released
Undecided
Robert Carr

Bug Description

When testing on a touch device to figure out if our event is a finger event vs a mouse event. Tool type == AMOTION_EVENT_TOOL_TYPE_UNKNOWN. Which should be AMOTION_EVENT_TOOL_TYPE_FINGER.

There should be tests in place that generate a tool type (finger/mouse) event and asserts our tool type is getting set correctly.

Related branches

lp:~mir-team/qtmir/fix-touch-tooltypes
PS Jenkins bot (community): Approve (continuous-integration)
Daniel d'Andrada (community): Approve
Gerry Boland (community): Needs Fixing
Diff: 19 lines (+8/-1)
1 file modified
src/modules/Unity/Application/mirsurfaceitem.cpp (+8/-1)
lp:ubuntu/utopic/qtmir
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Thanks for the bug report.

It's worth noting that touch apps/toolkits need to work even if the too type is not finger. Examples:
  * Using a stylus on a touch screen
  * Using a mouse with a touch screen

So make sure you're not only accepting tool type "finger".

Robert Carr (robertcarr)
Changed in mir:
status: New → Invalid
Changed in qtmir:
status: New → In Progress
assignee: nobody → Robert Carr (robertcarr)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Hmm, nothing needs fixing in Mir? Was there ever any evidence that Mir itself is reporting the wrong tool type or was it at a different layer like QtMir?

Changed in mir:
status: Invalid → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtmir - 0.4.3+14.10.20141001.5-0ubuntu1

---------------
qtmir (0.4.3+14.10.20141001.5-0ubuntu1) utopic; urgency=low

  [ Daniel d'Andrada ]
  * CONFIG+=no_tests to avoid building the tests and therefore speed up
    the build
  * Provide a global clipboard via D-Bus (LP: #1367814)

  [ josharenson ]
  * Remove check to see if application is already focused before
    focusing.

  [ Robert Carr ]
  * MirSurfaceItem::consume Set motion event tooltypes based on
    QTouchPoints (LP: #1371282)

  [ Gerry Boland ]
  * Fix AppMan handling Upstart resuming a Stopped application
 -- Ubuntu daily release <email address hidden> Wed, 01 Oct 2014 18:43:00 +0000

Changed in qtmir (Ubuntu):
status: New → Fix Released
Gerry Boland (gerboland)
Changed in qtmir:
status: In Progress → Fix Released
Daniel van Vugt (vanvugt)
no longer affects: mir
Michał Sawicz (saviq)
Changed in qtmir (Ubuntu):
assignee: nobody → Robert Carr (robertcarr)
no longer affects: qtmir
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.