Ability to specify script to call at end of download rather than rebooting

Bug #1376758 reported by James Hunt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu system image
Invalid
High
Barry Warsaw

Bug Description

Currently, after downloading the latest image, system-image-cli reboots the system.

It would be extremely useful if rather than hard-coding this, system-image-cli could conditionally call a hook script when it has finished. Ideally, it would be possible to specify this in /etc/system-image/client.ini

Since the desired behaviour could well be device/environment specific, maybe the reboot ability should also be pulled out of systemimage/reboot.py so that by default, /etc/system-image/hooks/default -> /etc/system-image/hooks/reboot.sh gets run, but that could be overriden via client.ini.

Tags: client
James Hunt (jamesodhunt)
summary: - Ability to specify script to call at end of download
+ Ability to specify script to call at end of download rather than
+ rebooting
Revision history for this message
Barry Warsaw (barry) wrote :

We have a [hooks]reboot setting in client.ini. The way to address this would be to add an appropriate implementation in a separate callable, and then point client.ini to this alternate implementation.

tags: added: client
no longer affects: system-image (Ubuntu)
Changed in ubuntu-system-image:
milestone: none → 3.0
status: New → Triaged
importance: Undecided → High
Revision history for this message
Michael Vogt (mvo) wrote :

The existing hook mechanism is fine IMO, the ubuntu-core-upgrader uses the "reboot" hook to apply the update successfully. The only wart left here is bug #1381538 - i.e. the name "reboot" for the hook is misleading because the core image will not always reboot, only when there are new kernels.

Revision history for this message
Barry Warsaw (barry) wrote :

Also, from the snappy branch:

system-image (2.5-0ubuntu1+ppa9) utopic; urgency=low

  * systemimage/data/client.ini:
    - use ubuntucoreupgrader.apply.ApplyUpgrade as the reboot hook

but I think this is a config file change.

Barry Warsaw (barry)
Changed in ubuntu-system-image:
assignee: nobody → Barry Warsaw (barry)
status: Triaged → In Progress
Revision history for this message
Barry Warsaw (barry) wrote :

I'm marking this one as invalid, but LP: #1381538 has been fixed.

Changed in ubuntu-system-image:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.