legacy apps re-set their notification status on reboot

Bug #1380662 reported by Oliver Grawert
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Canonical Devices Products
gsettings-ubuntu-touch-schemas (Ubuntu)
New
Low
Unassigned
ubuntu-push (Ubuntu)
Fix Released
High
John Lenton
ubuntu-push (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

when un-setting the notification defaults for "external drives" this setting is respected fine until i reboot my phone, after which the setting is auto-enabled again, regardless of what i chose before the reboot.

the same seems to be true for the "system-settings" option in the notifications panel. something like gmail or facebook persits fine

Tags: ota-1 rtm14

Related branches

Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

As far as I can tell, the setting was respected on start up (I did not get the notification from the external drives app) but was reset to receive notifications.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-system-settings (Ubuntu):
status: New → Confirmed
Revision history for this message
Roberto Alsina (ralsina) wrote :

This seems to affect only legacy apps (external drives and system-settings) and not every time.

The only difference in the setting between legacy and click apps is that legacy apps are stored like:

('', 'ciborium')

and click apps like:

('com.ubuntu.developer.webapps.webapp-facebook', 'webapp-facebook')

The entries are removed on boot, so it's not system settings that's deleting them. Is there something that checks gsettings against schemas that may be "cleaning" this?

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

I manually set the blacklist setting to various values and it seems anything with other than a valid name of a click package gets removed.
Something must be rewriting the blacklist, is it possible the push-client is doing this?
For example the following is retained:
[('com.ubuntu.developer.webapps.webapp-facebook', 'ciborium')]
but
[('', 'ciborium')]
is removed.

Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Roberto Alsina (ralsina)
importance: Undecided → High
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

I should add other non-blank entries are also removed such as
[('com.ubuntu.developer.ciborium', 'ciborium')]

tags: added: ota-1 rtm14
Revision history for this message
Roberto Alsina (ralsina) wrote : Re: [Bug 1380662] Re: legacy apps re-set their notification status on reboot

I played in the same lines and ('ciborium', 'ciborium') seems to survive.
There is no code outside of system settings that actually *writes* to this
setting at all.

On Tue, Oct 14, 2014 at 5:50 PM, Pat McGowan <email address hidden>
wrote:

> I manually set the blacklist setting to various values and it seems
> anything with other than a valid name of a click package gets removed.
> Something must be rewriting the blacklist, is it possible the push-client
> is doing this?
> For example the following is retained:
> [('com.ubuntu.developer.webapps.webapp-facebook', 'ciborium')]
> but
> [('', 'ciborium')]
> is removed.
>
>
> ** Changed in: ubuntu-system-settings (Ubuntu)
> Importance: Undecided => High
>
> ** Changed in: ubuntu-system-settings (Ubuntu)
> Assignee: (unassigned) => Roberto Alsina (ralsina)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1380662
>
> Title:
> legacy apps re-set their notification status on reboot
>
> Status in “ubuntu-system-settings” package in Ubuntu:
> Confirmed
>
> Bug description:
> when un-setting the notification defaults for "external drives" this
> setting is respected fine until i reboot my phone, after which the
> setting is auto-enabled again, regardless of what i chose before the
> reboot.
>
> the same seems to be true for the "system-settings" option in the
> notifications panel. something like gmail or facebook persits fine
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings/+bug/1380662/+subscriptions
>

Revision history for this message
Roberto Alsina (ralsina) wrote :

I am doing a branch with more logging just in case the code from settings
is being invoked by the settings wizard or whatever and it has to be fixed.

On Tue, Oct 14, 2014 at 6:05 PM, Roberto Alsina <
<email address hidden>> wrote:

> I played in the same lines and ('ciborium', 'ciborium') seems to survive.
> There is no code outside of system settings that actually *writes* to this
> setting at all.
>
> On Tue, Oct 14, 2014 at 5:50 PM, Pat McGowan <email address hidden>
> wrote:
>
>> I manually set the blacklist setting to various values and it seems
>> anything with other than a valid name of a click package gets removed.
>> Something must be rewriting the blacklist, is it possible the push-client
>> is doing this?
>> For example the following is retained:
>> [('com.ubuntu.developer.webapps.webapp-facebook', 'ciborium')]
>> but
>> [('', 'ciborium')]
>> is removed.
>>
>>
>> ** Changed in: ubuntu-system-settings (Ubuntu)
>> Importance: Undecided => High
>>
>> ** Changed in: ubuntu-system-settings (Ubuntu)
>> Assignee: (unassigned) => Roberto Alsina (ralsina)
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/1380662
>>
>> Title:
>> legacy apps re-set their notification status on reboot
>>
>> Status in “ubuntu-system-settings” package in Ubuntu:
>> Confirmed
>>
>> Bug description:
>> when un-setting the notification defaults for "external drives" this
>> setting is respected fine until i reboot my phone, after which the
>> setting is auto-enabled again, regardless of what i chose before the
>> reboot.
>>
>> the same seems to be true for the "system-settings" option in the
>> notifications panel. something like gmail or facebook persits fine
>>
>> To manage notifications about this bug go to:
>>
>> https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings/+bug/1380662/+subscriptions
>>
>
>

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

 scripts/click-hook in ubuntu-push has a "cleanup_settings()" that seems suspicious

Changed in ubuntu-system-settings (Ubuntu):
status: Confirmed → Invalid
Changed in ubuntu-push (Ubuntu):
assignee: nobody → Roberto Alsina (ralsina)
importance: Undecided → High
Revision history for this message
Sebastien Bacher (seb128) wrote :

that's not a settings issue, that application doesn't run on boot and can't be responsible for things happening then

Revision history for this message
Sebastien Bacher (seb128) wrote :

running /usr/lib/ubuntu-push-client/click-hook indeed empty that key

John Lenton (chipaca)
Changed in ubuntu-push (Ubuntu):
assignee: Roberto Alsina (ralsina) → John Lenton (chipaca)
Revision history for this message
John Lenton (chipaca) wrote :

Marked to affect also the gschema, as there is a documentation bug there that caused the misbehaviour of the cleanup script.

Changed in ubuntu-push (Ubuntu):
status: New → In Progress
Changed in ubuntu-system-settings (Ubuntu):
assignee: Roberto Alsina (ralsina) → John Lenton (chipaca)
Changed in gsettings-ubuntu-touch-schemas (Ubuntu):
assignee: nobody → John Lenton (chipaca)
status: New → In Progress
importance: Undecided → Low
Olli Ries (ories)
Changed in canonical-devices-system-image:
assignee: nobody → Canonical Devices Products (canonical-devices-products-team)
importance: Undecided → High
milestone: none → r1
status: New → Confirmed
Changed in canonical-devices-system-image:
milestone: ww51-2014 → ww05-2015
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-push - 0.64.1+15.04.20150116.2~rtm-0ubuntu1

---------------
ubuntu-push (0.64.1+15.04.20150116.2~rtm-0ubuntu1) 14.09; urgency=low

  [ John R. Lenton ]
  * Cherrypick r350 from automatic/ to turn down logs to info. (LP:
    #1376282, #1380662)
  * Cherrypick r342 from automatic/ to fix the click hook wrt legacy
    apps. (LP: #1380662)
 -- Ubuntu daily release <email address hidden> Fri, 16 Jan 2015 17:57:04 +0000

Changed in ubuntu-push (Ubuntu RTM):
status: New → Fix Released
Changed in ubuntu-push (Ubuntu):
status: In Progress → Fix Released
no longer affects: ubuntu-system-settings (Ubuntu)
Changed in gsettings-ubuntu-touch-schemas (Ubuntu):
status: In Progress → New
assignee: John Lenton (chipaca) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.