Mahara

Move all core plugin theme files into the /theme directory

Bug #1383995 reported by Aaron Wells
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Aaron Wells
Mahara 15.04.0

Bug Description

With https://bugs.launchpad.net/mahara/+bug/1231755 we now can store plugin theme files under the /theme directory *or* under the plugin's own directory (e.g. /blocktype/creativecommons).

I think it would be a good idea that for the "core" plugins (that ship with a standard Mahara install), we move their plugin files from each plugin's directory into the /theme directory. I believe this will make life easier for theme developers by centralizing all the theme files into one location.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3856

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Attaching the little PHP script I wrote to automatically git mv all the relevant files.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3856
Committed: http://gitorious.org/mahara/mahara/commit/89e4609b3e6c671637ca7bc601ab445d9cc75af2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 89e4609b3e6c671637ca7bc601ab445d9cc75af2
Author: Aaron Wells <email address hidden>
Date: Wed Oct 22 16:32:03 2014 +1300

Bug 1383995: Move plugin files into the /theme directory

Theme files for plugins can now live under the plugin's directory or under
the theme's directory. Moving the files for the core plugins to /theme
should make life easier for theme developers by putting them all in one place.

Change-Id: Icff863c46c80ed2d6be07cd49404bc0b7f5fc4c0

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Whoops, this patch caused a bug in the Wall block. If you go to a user's profile page, it crashes.

Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3862

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Pushed patch https://reviews.mahara.org/3862 to fix the problem with the Wall block. Turns out it was because:

1. I hadn't updated the pieforms custom template API to look for plugin theme files under /theme

2. And I had moved the blocktype/wall pieforms directory into the wrong place anyway.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3868

Revision history for this message
Aaron Wells (u-aaronw) wrote :

I've abandoned patch 3868 because it's a duplicate patch for the wall posts issue.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3862
Committed: http://gitorious.org/mahara/mahara/commit/bd44670666105642dd9b09eb06fc312884bc1e46
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit bd44670666105642dd9b09eb06fc312884bc1e46
Author: Aaron Wells <email address hidden>
Date: Thu Oct 23 17:56:18 2014 +1300

Support for plugin's custom pieforms templates in /theme

Bug 1383995

Change-Id: I97710ed51fd1944e871383b3331c95b534c1413a

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.