Ubuntu
lxc package

checkpoint restore fails with /usr/lib/x86_64-linux-gnu/lxc/lxc-restore-net: not found

Bug #1384751 reported by Tycho Andersen
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
lxc (Ubuntu)
Fix Released
High
Unassigned
Utopic
Fix Released
High
Unassigned
Vivid
Fix Released
High
Unassigned

Bug Description

================================================================
Impact: restoring containers from a checkpoint doesn't work
Development fix: LXC uses /usr/lib/x86_64-linux-gnu/lxc as the path to moun the container's root filesystem in its private mount namespace before it pivot_roots during restore. Unfortunately, that's also the location of the lxc-restore-net script which criu tries to execute. Since at this point the container's fs has already been mounted there, the callback (and thus the restore) fails.
Stable fix: Same as development fix
Testcase: create a container, then do:
    sudo lxc-checkpoint -n $foo -s -D /tmp/checkpoint
    sudo lxc-checkpoint -r -n $foo -D /tmp/checkpoint

    The restore fails with,

    sh: 1: /usr/lib/x86_64-linux-gnu/lxc/lxc-restore-net: not found

Regression potential: This can't effect anything besides lxc-checkpoint -r, which is broken anyways, so there should be no regressions.
================================================================

A patch for this has been posted to the upstream LXC list here:

https://lists.linuxcontainers.org/pipermail/lxc-devel/2014-October/010741.html

See original description
Serge Hallyn (serge-hallyn)
Changed in lxc:
importance: Undecided → High
status: New → Triaged
no longer affects: lxc
Changed in lxc (Ubuntu):
importance: Undecided → High
status: New → Triaged
Changed in lxc (Ubuntu Vivid):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in lxc (Ubuntu Vivid):
status: New → Confirmed
Revision history for this message
Tycho Andersen (tycho-s) wrote :

Here's a debdiff for the patch.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "lxc.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Tycho Andersen (tycho-s) wrote :

Sorry about that, turns out I copied and pasted from my terminal to create the file, which screwed up some whitespace. In any case, here's an updated debdiff that has been install tested.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 1.1.0~alpha2-0ubuntu4

---------------
lxc (1.1.0~alpha2-0ubuntu4) vivid; urgency=medium

  * install lxc-restore-net to /usr/share so that it doesn't get overmounted by
    the rootfs in preparation for restore. (LP: #1384751)
 -- Tycho Andersen <email address hidden> Mon, 27 Oct 2014 19:36:21 -0500

Changed in lxc (Ubuntu Vivid):
status: Confirmed → Fix Released
Tycho Andersen (tycho-s)
description: updated
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Tycho, or anyone else affected,

Accepted lxc into utopic-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lxc/1.1.0~alpha2-0ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lxc (Ubuntu Utopic):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Sebastien Bacher (seb128) wrote :

(seems like the changes here got uploaded, unsubscribing sponsors)

Tycho Andersen (tycho-s)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 1.1.0~alpha2-0ubuntu3.1

---------------
lxc (1.1.0~alpha2-0ubuntu3.1) utopic; urgency=medium

  * install lxc-restore-net to /usr/share so that it doesn't get overmounted by
    the rootfs in preparation for restore. (LP: #1384751)
 -- Tycho Andersen <email address hidden> Wed, 12 Nov 2014 09:57:39 -0600

Changed in lxc (Ubuntu Utopic):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for lxc has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.