API does not follow QML style

After this change, the example in here [1] can be updated to use the QML style of doing things, which also has the advantage that it allows removing the undefined reference to messageList from the example code.

[1] http://developer.ubuntu.com/apps/platform/guides/push-notifications-client-guide/

Well, the “undefined reference” would remain, because you want to handle notifications as they come in (right? or is there a more QMLish way of doing that too?), and the error handler would still be that.

I know *no* QML; can the error handler be specified as

    onError: messageList.handle_error

or does it have to be

    onError: {
        messageList.handle_error(error)
    }

?

We should probably change the example to make it explicit that messageList is some other part of the app you're building.

same there. You'd do:

PushClient {
  onNotificationsChanged: {
    print("got notifications:", notifications)
    // Do something useful with them
  }
}

Not saying that's the best to put into the example code, but you could even do something like:

PushClient {
  id: pushClient
}

ListView {
  model: pushClient.notifications
}

This would automatically update the listview whenever the notifications change.

For the example I'd go for:

PushClient {
  onError: {
    console.warn("PushClient error:", error)
  }
  onNotificationsChanged: {
    console.log("Notifications received:", notifications)
    // Do something useful with them
  }
}

(I did not test this, so there might be some typos or similar, but I'm sure you get the idea)

This bug was fixed in the package ubuntu-push-qml - 0.1+15.04.20141117-0ubuntu1

---------------
ubuntu-push-qml (0.1+15.04.20141117-0ubuntu1) vivid; urgency=low

  [ Michael Zanetti ]
  * constify, use references and add parameter names (LP: #1393261)
 -- Ubuntu daily release <email address hidden> Mon, 17 Nov 2014 16:46:19 +0000