Phone numbers are stored as formatted strings and are not found when searching
Bug #1400468 reported by
Pat McGowan
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Critical
|
Unassigned | ||
| address-book-app |
Fix Released
|
Critical
|
Renato Araujo Oliveira Filho | ||
| address-book-app (Ubuntu) |
Fix Released
|
Critical
|
Renato Araujo Oliveira Filho | ||
| address-book-app (Ubuntu RTM) |
Fix Released
|
Critical
|
Renato Araujo Oliveira Filho | ||
Bug Description
There are several problems:
Search currently requires the user to enter a "space" or "-" character to find matching numbers the the contacts and messaging apps.
Also depending on how the number is entered the formatting is different for example:
19995551212 is stored and displayed as "1 999-555-1212"
whereas
9995551212 is displayed as "(999) 555-1212"
There is no way for me to specify a formatted number when creating a contact so there is no real reason to store it formatted in a way we choose.
When editing a number I am presented with it formatted which is somewhat confusing, there is no "-" character available to me.
I suggest we store the raw number only and always normalize search strings to digits and special characters (like *#) only. The presentation should be considered separate from the data
Related branches
lp:~renatofilho/address-book-app/fix-1400468
- Bill Filler (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Pat McGowan (community): Approve
-
Diff: 19 lines (+1/-8)1 file modifiedsrc/imports/Ubuntu/Contacts/ContactListModel.qml (+1/-8)
lp:~renatofilho/telephony-service/fix-1400468
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 18 lines (+7/-1)1 file modifiedUbuntu/Telephony/contactwatcher.cpp (+7/-1)
lp:~bfiller/address-book-app/fix-search-by-name
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 210 lines (+159/-10)4 files modifiedsrc/imports/Ubuntu/Contacts/ContactListModel.qml (+21/-10)
tests/data/tst_ContactListModel_data.vcf (+30/-0)
tests/qml/CMakeLists.txt (+2/-0)
tests/qml/tst_ContactListModel.qml (+106/-0)
lp:~renatofilho/address-book-app/fix-1400468-rtm
- Ubuntu Phablet Team: Pending requested
-
Diff: 246 lines (+166/-20)6 files modifieddebian/control (+1/-0)
debian/rules (+3/-0)
src/imports/Ubuntu/Contacts/ContactListModel.qml (+24/-20)
tests/data/tst_ContactListModel_data.vcf (+30/-0)
tests/qml/CMakeLists.txt (+2/-0)
tests/qml/tst_ContactListModel.qml (+106/-0)
| Changed in address-book-app (Ubuntu): | |
| assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
| importance: | Undecided → Critical |
| status: | New → Confirmed |
Revision history for this message
| Pat McGowan (pat-mcgowan) wrote | #1 |
| Changed in address-book-app (Ubuntu): | |
| importance: | Critical → High |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → Critical |
| milestone: | none → ww51-2014 |
| status: | New → Confirmed |
Revision history for this message
| Pat McGowan (pat-mcgowan) wrote | #2 |
| tags: | added: ww51 |
| Changed in address-book-app (Ubuntu): | |
| status: | Confirmed → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in address-book-app (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| Bill Filler (bfiller) wrote | #4 |
| Changed in address-book-app: | |
| importance: | Undecided → Critical |
| status: | New → In Progress |
| Changed in address-book-app (Ubuntu): | |
| status: | Fix Released → In Progress |
| importance: | High → Critical |
| Changed in address-book-app: | |
| assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
| Changed in address-book-app (Ubuntu RTM): | |
| status: | New → In Progress |
| importance: | Undecided → Critical |
| assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in address-book-app (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #6 |
| Changed in address-book-app (Ubuntu RTM): | |
| status: | In Progress → Fix Released |
| Changed in address-book-app: | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
drop to high sincee search is probably mainly on the name not number