Mahara

Cannot cancel comment form after validation fails

Bug #1400511 reported by Yuliya Bozhko
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Yuliya Bozhko
Mahara 15.04.0
1.10
Fix Released
Low
Unassigned
Mahara 1.10.2
1.8
Fix Released
Low
Unassigned
Mahara 1.8.7
1.9
Fix Released
Low
Unassigned
Mahara 1.9.5
15.04
Fix Released
Low
Yuliya Bozhko
Mahara 15.04.0

Bug Description

To reproduce:

1. Go to any page
2. Submit an empty comment
3. See the form validation fail.
4. Now try to cancel the form.

What should happen: form should be cancelled

What happens: JS error, "Cannot read property 'tablerows' of undefined"...

Revision history for this message
Aaron Wells (u-aaronw) wrote :

A quick look indicates this problem has existed at least since Mahara 1.5!

Since it's a low-priority bug, it's probably not worth backporting to any earlier than 1.10, though.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Yuliya's patch for this bug: https://reviews.mahara.org/#/c/4065/

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4065
Committed: http://gitorious.org/mahara/mahara/commit/55f3b731b3e0898581469d33f4c206bdf91f835e
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 55f3b731b3e0898581469d33f4c206bdf91f835e
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/4074

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4074
Committed: http://gitorious.org/mahara/mahara/commit/3a44d1ed730aac28b7d0439f575ca94f688fa992
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 3a44d1ed730aac28b7d0439f575ca94f688fa992
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/4075

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/4076

Revision history for this message
Aaron Wells (u-aaronw) wrote :

On second thought, it's such a small, sensible code change, and it applies cleanly to 1.8 & 1.9 and works in them, so I've gone ahead and backported it to them as well.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4075
Committed: http://gitorious.org/mahara/mahara/commit/f89e097604602a034ba0cad39a4c3c72b03b2436
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.9_STABLE

commit f89e097604602a034ba0cad39a4c3c72b03b2436
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4076
Committed: http://gitorious.org/mahara/mahara/commit/2bf7c3833b3ad8e0c2a568b37c9f1366b550b215
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.8_STABLE

commit 2bf7c3833b3ad8e0c2a568b37c9f1366b550b215
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.