Mahara

don't allow the choosing of skin for dashboard page

Bug #1419959 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 15.04.0

Bug Description

As the dashboard is not meant to be shared it and that it's kind of a quasi admin page I feel it shouldn't be skinned.

So will add a patch to stop it from being allowed to pick a skin in the edit screen.

As one can currently pick a skin for it - but not have it display this can cause confusion so will make this a medium bug

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4261

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Makes sense to me.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4261
Committed: http://gitorious.org/mahara/mahara/commit/c33bb9efa5f6dedbe547aed7879072943ae01baa
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit c33bb9efa5f6dedbe547aed7879072943ae01baa
Author: Robert Lyon <email address hidden>
Date: Tue Feb 10 08:46:06 2015 +1300

Stopping the 'skins' tab showing for dashboard (Bug #1419959)

This is on the page edit screen

Change-Id: I1e96837c2292cbf9fb6c44bcb291bf722b079329
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Robert Lyon (robertl-9) wrote :

The previous patch didn't take into account mysql - so will need to add another patch to fix this issue

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4271

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4271
Committed: http://gitorious.org/mahara/mahara/commit/46581b133df3de1c5e8c151ebc92925b18e27047
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 46581b133df3de1c5e8c151ebc92925b18e27047
Author: Robert Lyon <email address hidden>
Date: Fri Feb 13 07:32:01 2015 +1300

Fixing skin update sql for mysql (Bug #1419959)

Needed to use a temp table as update and select are from same table

Change-Id: Idddf6048b2f6cf6cff2fadad87b8703a56a7a8d5
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Note for myself for the user manual update: Mention which pages can have a skin.

tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.