openafs-modules-dkms 1.6.7-1: openafs kernel module failed to build

Bug #1423151 reported by Fabian Boehnlein
302
This bug affects 61 people
Affects Status Importance Assigned to Milestone
openafs (Ubuntu)
Fix Released
Undecided
Achim Bohnet
Trusty
Fix Released
Medium
Louis Bouchard
Utopic
Fix Released
Medium
Louis Bouchard

Bug Description

[SRU justification]
The openafs-modules-dkms package fails to build its modules following kernel upgrade

[Impact]
No longer possible to use openafs kernel module

[Fix]
Backport the dentry changes into the current package.

[Test Case]
Install the openafs-modules-dkms
With the fix :
 $ sudo apt-get install openafs-modules-dkms
 Loading new openafs-1.6.7 DKMS files...
 Building only for 3.13.0-46-generic
 Building initial module for 3.13.0-46-generic
 Done.

 openafs:
 Running module version sanity check.
  - Original module
    - No original module exists within this kernel
  - Installation
    - Installing to /lib/modules/3.13.0-46-generic/updates/dkms/

 depmod....

 DKMS: install completed.

Without the fix :

 $ sudo apt-get install openafs-modules-dkms
 Loading new openafs-1.6.7 DKMS files...
 Building only for 3.13.0-46-generic
 Building initial module for 3.13.0-46-generic
 Error! Bad return status for module build on kernel: 3.13.0-46-generic (x86_64)
 Consult /var/lib/dkms/openafs/1.6.7/build/make.log for more information.

[Regression]
The applied changes are from upstream and present in Vivid.
Two #includes have been taken out of another commit to
[Original description of the problem]

fails on update

ProblemType: Package
DistroRelease: Ubuntu 14.04
Package: openafs-modules-dkms 1.6.7-1
ProcVersionSignature: Ubuntu 3.13.0-45.74-generic 3.13.11-ckt13
Uname: Linux 3.13.0-45-generic x86_64
NonfreeKernelModules: openafs
ApportVersion: 2.14.1-0ubuntu3.7
Architecture: amd64
DKMSKernelVersion: 3.13.0-46-generic
Date: Wed Feb 18 12:19:38 2015
DuplicateSignature: dkms:openafs-modules-dkms:1.6.7-1:/var/lib/dkms/openafs/1.6.7/build/src/libafs/MODLOAD-3.13.0-46-generic-SP/afs_daemons.c:403:24: error: ‘struct dentry’ has no member named ‘d_alias’
InstallationDate: Installed on 2014-12-15 (64 days ago)
InstallationMedia: Ubuntu 14.04.1 LTS "Trusty Tahr" - Release amd64 (20140722.2)
PackageArchitecture: all
PackageVersion: 1.6.7-1
SourcePackage: openafs
Title: openafs-modules-dkms 1.6.7-1: openafs kernel module failed to build
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Fabian Boehnlein (fabian-boehnlein) wrote :
tags: removed: need-duplicate-check
Revision history for this message
Sergio Gelato (sergio-gelato) wrote :

This is due to the backport of a kernel change:
  move d_rcu from overlapping d_child to overlapping d_alias
to 3.2.0-76.111 and 3.13.0-46.*.

The OpenAFS package in Debian sid (1.6.10-4) has the necessary fixes. If you want to cherry-pick them, try the patches I'll attach shortly.

Revision history for this message
Sergio Gelato (sergio-gelato) wrote :
Revision history for this message
Sergio Gelato (sergio-gelato) wrote :
Changed in openafs (Ubuntu):
status: New → Confirmed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Part 1 (upstream) patch for this problem" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Fabian Boehnlein (fabian-boehnlein) wrote :

Thanks. Installing openafs-client with dependencies from debian sid will break because of Perl pre-dependencies. Picking openafs-modules-dkms from debian sid and then apt-getting openafs-client works.

Revision history for this message
ThomasA (thomas-arildsen) wrote :

Is someone putting this into an update for Ubuntu 14.04? I rely heavily on AFS and would desparately like to get it working again.

Revision history for this message
Patrik Lundin (patrik-lundin) wrote :
Revision history for this message
Amos (a-storkey) wrote :

Not "also". It hasn't yet been fixed in -updates for 14.04.

Revision history for this message
Achim Bohnet (allee) wrote :

I've taken the patches Sergio provided in #3 and #4 and created a pkg out of it. Uploaded right now at:

  https://launchpad.net/~allee/+archive/ubuntu/test

Test: module build now again with 3.13.0-45-generic trusty kernel and find /afs/ourcell/bigsubdir -ls > /dev/null
worked without error on cmdline or kern.log.

Warning: I've no idea about openafs kernel sources. I just happen to know how to build a package.

Revision history for this message
Patrik Lundin (patrik-lundin) wrote :

Amos: the "also" referred to the Debian sid package.

Revision history for this message
Achim Bohnet (allee) wrote :

For build log see ppa:allee/test/

Achim Bohnet (allee)
Changed in openafs (Ubuntu):
assignee: nobody → Achim Bohnet (allee)
status: Confirmed → Fix Committed
Louis Bouchard (louis)
Changed in openafs (Ubuntu Trusty):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Louis Bouchard (louis-bouchard)
Revision history for this message
Louis Bouchard (louis) wrote :

Marking the development release as Invalid since the vivid version (1.6.10-4) has the fix. Only trusty and utopic is concerned by that issue.

Taking care of Trusty for the time being

Revision history for this message
Luigi Calligaris (luigicalligaris) wrote :

Achim fix works for me. I'm running 3.13.0-46-generic on Trusty

Revision history for this message
Lucas Teixeira (weblucas) wrote :

Achim fix works for me as well on Trusty

Revision history for this message
Louis Bouchard (louis) wrote :

Thanks for the tests. I'm just doing a last test at the second part of the provided patch and will take care of the SRU. I'll keep you posted here.

Louis Bouchard (louis)
tags: added: cts
Louis Bouchard (louis)
Changed in openafs (Ubuntu Trusty):
status: Triaged → In Progress
Revision history for this message
Louis Bouchard (louis) wrote :

debdiff for trusty

description: updated
Revision history for this message
Louis Bouchard (louis) wrote :

Achim, I adapted your patch into one single quilt patch with added DEP3 information. I also changed the changelog to include bug attribution to you.

Revision history for this message
Louis Bouchard (louis) wrote :

Sorry Achim, I was wrong, the attribution is to Sergio who authored the patch. My bad

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Fabian, or anyone else affected,

Accepted openafs into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.6.7-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in openafs (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Christoph (f-ubuntuone-6) wrote :

1.6.7-1ubuntu1 from -proposed works for me. The module installs fine and I can mount and access the afs.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Louis Bouchard (louis) wrote :

I just tested the package in -propose and it builds correctly. It would be more useful if someone with a real openafs infrastructure could test it & change the tag to "verification-done". Otherwise, I will change it myself by the end of the week.

Revision history for this message
Louis Bouchard (louis) wrote :

Thanks Christoph, I missed your update before posting :-)

Revision history for this message
Torbjörn Moa (moa-physto) wrote :

In case it helps anyone, I can confirm that 1.6.7-1ubuntu1 from -proposed installs and works correctly.

Revision history for this message
Dennis Schridde (devurandom) wrote :

Thanks! I just installed openafs-modules-dkms_1.6.7-1ubuntu1, ran "modprobe openafs", "/etc/init.d/openafs restart", renewed my logon and have access to my files again! :)

Revision history for this message
David Hoffman (hoffman) wrote :

Just upgraded to openafs-modules-dkms 1.6.7-1ubuntu1 via trusty-proposed. Module built successfully, restarted openafs-client, and now /afs appears to be working properly.

Revision history for this message
Micheal Waltz (ecliptik) wrote :

Tested version 1.6.7-1ubuntu1 of the openafs packages from -proposed and it installed the openafs-modules-dkms package and built the openafs kernel module properly on kernel 3.13.0-46-generic.

||/ Name Version Architecture Description
+++-=================-=============-=============-========================================
ii linux-image-3.13. 3.13.0-46.77 amd64 Linux kernel image for version 3.13.0 on
ii linux-image-extra 3.13.0-46.77 amd64 Linux kernel extra modules for version 3
ii linux-image-gener 3.13.0.46.53 amd64 Generic Linux kernel image
ii openafs-client 1.6.7-1ubuntu amd64 AFS distributed filesystem client suppor
ii openafs-doc 1.6.7-1ubuntu all AFS distributed filesystem documentation
ii openafs-krb5 1.6.7-1ubuntu amd64 AFS distributed filesystem Kerberos 5 in
ii openafs-modules-d 1.6.7-1ubuntu all AFS distributed filesystem kernel module

uname -a
Linux proposed-ubuntu-s-1404-amd64-afs-development 3.13.0-46-generic #77-Ubuntu SMP Mon Mar 2 18:23:39 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

modinfo openafs
filename: /lib/modules/3.13.0-46-generic/updates/dkms/openafs.ko
license: http://www.openafs.org/dl/license10.html
srcversion: 8EDC2AADAC77ED454BC5D7F
depends:
vermagic: 3.13.0-46-generic SMP mod_unload modversions

Revision history for this message
seth goldstein (seth-o) wrote :

I would like to test this out (I really need afs badly), but I am not sure how do it. I followed the dirextins at https://wiki.ubuntu.com/Testing/EnableProposed, i.e.,

Added to /etc/apt/sources.list:

deb http://archive.ubuntu.com/ubuntu trusty-proposed restricted main multiverse universe

Created the file /etc/apt/preferences.d/proposed-updates with:

Package: *
Pin: release a=trusty-proposed
Pin-Priority: 400

And tried to do an upgrade. Not sure what package to upgrade. For example, I tried:

sudo apt-get install openafs-modules-dkms/trusty-proposed
sudo apt-get install openafs-client/trusty-proposed

and some others and they all report:

E: Release 'trusty-proposed' for 'openafs-modules-dkms' was not found

How do I proceed?

Revision history for this message
seth goldstein (seth-o) wrote :

I figured it out and installed the proposed package. It compiled and installed fine and afs is back up!

Revision history for this message
nasim (farahini) wrote :

Hi,

I have the same question as seth. Can you tell what the proposed packages are and how to install them??

Revision history for this message
seth goldstein (seth-o) wrote :

In order to get things to work I basically followed the directions at
https://wiki.ubuntu.com/Testing/EnableProposed. However, it did not
initially work. I am not sure exactly which of the below got things
to work, but eventually it did. So here are the steps I went through:

Editted /etc/apt/sources.list to add:

deb http://archive.ubuntu.com/ubuntu/ trusty-proposed restricted main multiverse universe

Created file /etc/apt/preferences.d/proposed-updates with this content:

Package: *
Pin: release a=trusty-proposed
Pin-Priority: 400

In an xterm ran:

sudo aptitude -t trusty-proposed

And, there was nothing there. Then, I launched "Software & Updates"
and it showed that the pre-released updates box was checked and
exitted.

Then, I restarted apititude, did an update and voila there were 90
packages. I browsed through them and found

openafs-modules-dkms under the 'net' catagory of 'upgradable
packages'. I picked this with a '+' and then installed with a 'g'.
Everything worked fine.

Revision history for this message
Richard Feltstykket (rafeltstykket) wrote :

Applied the release from trusty-proposed as well. Appears to work fine.

Revision history for this message
Torbjörn Moa (moa-physto) wrote :

Would it be possible to get the 1.6.7-1ubuntu1 packages into trusty-update anytime soon?

Revision history for this message
ThomasA (thomas-arildsen) wrote :

It seems I can install the new version from the proposed channel, but I can no longer authenticate now:

    $ klog
    klog: unknown RPC error (-1765328164) Unable to authenticate in realm

Revision history for this message
Juraj (juraj-knoska) wrote :

proposed 1.6.7-1ubuntu1 package worked for me perfectly, thanks!

Revision history for this message
Achim Bohnet (allee) wrote :

proposed 1.6.7-1ubuntu1 works here too!

In case someone installed my test package from comment #10
  https://launchpad.net/~allee/+archive/ubuntu/test
the package revision used there 1.6.7-1+ubuntu0.1~ppa1
is and will be bigger than the 'offical' revision(s) used 1.6.7-1ubuntu*

So if you installed for testing the package from my ppa, please
downgrade to the official package with

  sudo apt-get install $(dpkg -l \*openafs\* | awk '/^i/{print $2 "=1.6.7-1ubuntu1"}')

Sorry, for the additional trouble,
Achim

Revision history for this message
ThomasA (thomas-arildsen) wrote :

Strangely, it worked for me when I installed Achim's package above. My problems in https://bugs.launchpad.net/ubuntu/trusty/+source/openafs/+bug/1423151/comments/34 appeared when I removed the package from Achim's PPA and installed the one from trusty-proposed instead.

Revision history for this message
ThomasA (thomas-arildsen) wrote :

I have just now confirmed that the package from trusty-proposed works for me on another computer than the one in question above. I am going to retry installing it from scratch on the above computer to see if I can fix it.

Revision history for this message
Achim Bohnet (allee) wrote :

@ThomasA: try klog.afs instead of klog. The error message lock like you use klog.krb5 now.

    ls -l /usr/bin/klog* /etc/alternatives/klog

If klog.afs works for you use:

sudo update-alternatives --config klog

to fix it.

Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for openafs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package openafs - 1.6.7-1ubuntu1

---------------
openafs (1.6.7-1ubuntu1) trusty; urgency=medium

  [Sergio Gelato <email address hidden>]
  * debian/patches/lp1423151_fix_dmks_build.patch:
   - Fix DKMS build failure following a rearrangement
     of the dentry struct in kernel from 3.18 onward.
     (LP: #1423151)
 -- Louis Bouchard <email address hidden> Wed, 04 Mar 2015 10:34:14 +0100

Changed in openafs (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Jeffrey Stern (jas-61803) wrote :

Okay, (and sorry if this is a newbie question) .. this so far is just for Trusty, right? Will there be a separate bug posted for Utopic? thx..

Revision history for this message
Anders Kaseorg (andersk) wrote :
Louis Bouchard (louis)
Changed in openafs (Ubuntu Utopic):
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Louis Bouchard (louis-bouchard)
Louis Bouchard (louis)
Changed in openafs (Ubuntu Utopic):
status: Confirmed → In Progress
Revision history for this message
Louis Bouchard (louis) wrote :

debdiff for Utopic

Revision history for this message
kostas (gladia26) wrote :

package openafs-client 1.6.7-1ubuntu1 failed to install/upgrade: η υποδιεργασία installed post-installation script return eror 2

Revision history for this message
Achim Bohnet (allee) wrote :

@kostas: you use kernel 3.13? Or the -lts-utopic one 3.16? With lts-utopic kernel there still a problem. See https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1431312

Revision history for this message
ThomasA (thomas-arildsen) wrote :

@Achim: I have now removed the openafs packages from my system and re-installed "openafs-client" (and dependencies) from the updates channel. `klog` works again now. Hard to say exactly what went wrong in the process but at least it is back in working condition now.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Fabian, or anyone else affected,

Accepted openafs into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.6.9-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in openafs (Ubuntu Utopic):
status: In Progress → Fix Committed
tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Micheal Waltz (ecliptik) wrote :

Could this fix also added to precise-backports for 12.04 HWE Trusty installs?

I've filed https://bugs.launchpad.net/precise-backports/+bug/1324288 for this with the relevant information.

Revision history for this message
Micheal Waltz (ecliptik) wrote :

My apologies, wrong copy/paste link in my comment above, the LP bug for precise-backports is:

https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1434254

Revision history for this message
Achim Bohnet (allee) wrote :

utopic: +1 Installed 1.6.9-2ubuntu1 from utopic-proposed on a utopic laptop and desktop. Kernel module builds and opeanfs-client works again (listings files and copy to from afs).

Revision history for this message
Jeffrey Stern (jas-61803) wrote :

success here as well: per Brian's request, I installed and minimally tested the relevant packages i needed(*) from the utopic-proposed repo. Kernel module builds, and directory listings, file create/modify/delete, copy to/from afs all work well.

[utopic/Ubuntu 14.10 desktop. latest released/stable kernel (3.16.0-33-generic #44-Ubuntu SMP Thu Mar 12 12:19:35 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux)]

(*) openafs-client
openafs-doc (i know, optional)
openafs-krb5
openafs-modules-dkms
openafs-modules-source

let me know if you need anything else tested.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package openafs - 1.6.9-2ubuntu1

---------------
openafs (1.6.9-2ubuntu1) utopic; urgency=medium

  [Sergio Gelato <email address hidden>]
  * debian/patches/0003-lp1423151_fix_dmks_build.patch:
   - Fix DKMS build failure following a rearrangement
     of the dentry struct in kernel from 3.18 onward.
     That kernel modification has been backported to 3.16.
     (LP: #1423151)
 -- Louis Bouchard <email address hidden> Fri, 13 Mar 2015 10:47:56 +0100

Changed in openafs (Ubuntu Utopic):
status: Fix Committed → Fix Released
Revision history for this message
seth goldstein (seth-u) wrote :

I would like to try this out. How can I install from utopic proposed? I tried:

sudo apt-get install openafs-modules-dkms/proposed and
sudo apt-get install openafs-modules-dkms/utopic-proposed

In both cases I get an error, e.g.,: E: Release 'utopic-proposed' for 'openafs-modules-dkms' was not found

Revision history for this message
Achim Bohnet (allee) wrote :

@Seth: check comment #20, #31 or #48 on how to enable proposed.

Revision history for this message
Dennis Schridde (devurandom) wrote :

The issue is back on 14.04 Trusty with LTS HWE from Utopic:
/var/lib/dkms/openafs/1.6.7/build/src/libafs/MODLOAD-3.16.0-34-generic-SP/osi_vnodeops.c:815:19: error: ‘generic_file_splice_write’ undeclared here (not in a function)
   .splice_write = generic_file_splice_write,
                   ^

Revision history for this message
Dennis Schridde (devurandom) wrote :

comment #56 is bug #1433411

flecken (devil6)
Changed in openafs (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.